From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Move gdbserver to top level
Date: Tue, 28 Jan 2020 00:37:00 -0000 [thread overview]
Message-ID: <87o8uo4mj0.fsf@tromey.com> (raw)
In-Reply-To: <01b4b5ca-a802-54b5-3135-428b7c9faa84@redhat.com> (Pedro Alves's message of "Mon, 27 Jan 2020 13:41:06 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I guess it's the intended design for top level to build readline, bfd,
Pedro> etc. by default even if no application is being built that depends
Pedro> on them. I don't know.
Me neither, but it seems to me that we could try to change it. My
mental model is that there are certain top-level build targets (gdb, or
binutils) and the rest are just dependencies of those. So, we could try
not to build these dependencies unless there's a need.
Pedro> People may trip on this if they try to build gdbserver for a port
Pedro> for which one of those top level dirs doesn't build, like bfd.
Pedro> powerpc-lynxos is I think one such case, but there are probably
Pedro> others in the non-glibc space, and also off tree.
FWIW there is a problem here I haven't solved yet. Right now, the
top-level gdbsupport depends on BFD. This is needed for common-types.h.
However, this introduces a conflict if we want to share the top-level
gdbsupport with gdbserver.
I'm not totally sure what to do here. Maybe we could replicate the BFD
type-configury code? Like, break it out into a new .m4 file for
sharing. It's been a while though, so I forget why, but I thought I had
some reason this wouldn't work.
Pedro> So I'm thinking that it might be better to document "make
Pedro> all-gdbserver" instead of the --disable approach. Or at least,
Pedro> mention it as alternative. WDYT?
Makes sense, though I may take a stab at fixing the top-level instead.
Pedro> However, looking at how libatomic, liboffloadmic, etc.
Pedro> handle this at the top level, I see that the top level
Pedro> sources a file that is also sourced by their respective
Pedro> configures. I.e., the file sourced served a dual purpose.
Pedro> From the top level, the file is sourced in subshell, which
Pedro> avoids variable polluting the top level. This has the advantage
Pedro> that you only have to write support for a port once in one file,
Pedro> instead of in two places.
Pedro> The equivalent for gdbserver would be the patch below,
Pedro> which seems to work well. Was there a reason you didn't follow
Pedro> libatomic's (etc.) model?
I just didn't think of it. I like your idea better, though, because it
means not duplicating information.
Tom
next prev parent reply other threads:[~2020-01-27 21:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 20:07 Tom Tromey
2020-01-21 5:34 ` Simon Marchi
2020-01-23 22:03 ` Tom Tromey
2020-01-24 14:29 ` Hannes Domani via gdb-patches
2020-01-24 15:12 ` Tom Tromey
2020-01-24 15:57 ` Tom Tromey
2020-01-24 16:02 ` Hannes Domani via gdb-patches
2020-01-24 16:28 ` Tom Tromey
2020-01-24 16:35 ` Hannes Domani via gdb-patches
2020-01-24 19:03 ` Hannes Domani via gdb-patches
2020-01-24 15:23 ` Pedro Alves
2020-01-25 0:07 ` Tom Tromey
2020-01-25 16:55 ` Pedro Alves
2020-01-26 16:01 ` Tom Tromey
2020-01-27 18:13 ` Pedro Alves
2020-01-28 0:37 ` Tom Tromey [this message]
2020-02-03 21:34 ` Tom Tromey
2020-02-07 16:06 ` Simon Marchi
2020-02-09 13:59 ` Tom de Vries
2020-02-09 14:17 ` Tom de Vries
2020-02-10 10:01 ` Tom de Vries
2020-02-10 15:54 ` Sergio Durigan Junior
2020-02-12 0:55 ` Tom Tromey
2020-02-12 16:47 ` Sergio Durigan Junior
2020-02-14 3:54 ` Sergio Durigan Junior
2020-02-14 18:43 ` Tom Tromey
2020-02-14 21:14 ` Tom Tromey
2020-02-17 13:58 ` Luis Machado
2020-02-17 14:21 ` Maciej W. Rozycki
2020-02-17 14:29 ` Luis Machado
2020-02-17 16:57 ` Luis Machado
2020-02-17 17:01 ` Tom Tromey
2020-02-17 17:28 ` Aktemur, Tankut Baris
2020-02-17 18:46 ` Tom Tromey
2020-02-10 10:59 ` [PATCH][gdb/testsuite] Skip multi-target.exp without gdbserver Tom de Vries
2020-02-10 12:20 ` Pedro Alves
2020-02-09 23:05 ` [PATCH] Move gdbserver to top level Alan Modra
2020-02-10 12:02 ` Pedro Alves
2020-02-10 9:52 ` Andreas Schwab
2020-02-10 12:13 ` Pedro Alves
2020-02-10 13:04 ` Andreas Schwab
2020-02-10 13:15 ` Andreas Schwab
2020-02-11 13:48 ` [PATCH] Disable gdbserver on host != target configurations (Re: [PATCH] Move gdbserver to top level) Pedro Alves
2020-02-11 15:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8uo4mj0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox