From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.202]) by sourceware.org (Postfix) with ESMTPS id 120453959E7E for ; Tue, 10 Mar 2020 16:40:20 +0000 (GMT) Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 4F8BE1EF90 for ; Tue, 10 Mar 2020 11:40:19 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BhvWjMbWfEfyqBhvXjP0F3; Tue, 10 Mar 2020 11:40:19 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OqeNxNkeRM71DuvoJyWjdnFrSS9kkj48x0MUcJ3fpb8=; b=xUYZYZOtZsdbijQpX23qtGB1dm X6p7O6FnXVx7wqwZxQCeA/95AzuVQAR7DwiwegTvB64StMHG3KOPevYHvWDX9xvjCpSsQeqGZvMlr 0cSDHEobkdHZBX5BilJT6synv; Received: from 184-96-250-69.hlrn.qwest.net ([184.96.250.69]:41048 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jBhvW-001zB6-Es; Tue, 10 Mar 2020 10:40:18 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb] Fix segv in "maint print symbols" for ada exec References: <20200310140825.GA20400@delia> X-Attribution: Tom Date: Tue, 10 Mar 2020 10:40:17 -0600 In-Reply-To: <20200310140825.GA20400@delia> (Tom de Vries's message of "Tue, 10 Mar 2020 15:08:26 +0100") Message-ID: <87o8t4rwni.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.250.69 X-Source-L: No X-Exim-ID: 1jBhvW-001zB6-Es X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-250-69.hlrn.qwest.net (murgatroyd) [184.96.250.69]:41048 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2020 16:40:22 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> What happens is that dwarf2_evaluate_property gets called and sets the local Tom> frame variable to the current frame, which happens to be NULL. Subsequently Tom> the PROP_LOCLIST handling code is executed, where get_frame_address_in_block Tom> gets called with argument NULL, and the segv is triggered. Tom> Fix this by handling a NULL frame in the PROP_LOCLIST handling code in Tom> dwarf2_evaluate_property. Thank you for doing this. This seems reasonable. I had one request... Tom> clean_restart ${testfile} Tom> +gdb_test_no_output "maint expand-symtabs" Tom> +gdb_test "set logging redirect on" Tom> +gdb_test "set logging on" Tom> +gdb_test "maint print symbols" Tom> +gdb_test "set logging off" Tom> +file delete gdb.txt I think this code should set the logging file to something in the output directory. This way if other tests do the same thing, there won't be a possibility of a clash. After this, there's no real need to delete the file; though it's fine if you still want to do that. Tom