From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.156]) by sourceware.org (Postfix) with ESMTPS id 2B709389366C for ; Fri, 24 Apr 2020 14:00:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B709389366C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id B1B1F674D for ; Fri, 24 Apr 2020 09:00:05 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Rys8jY9iz8vkBRys9jIeWu; Fri, 24 Apr 2020 09:00:05 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aG6B+NMEGu1hhYEM8eP6RCPrkP2axFS4M9ONBBxGoE0=; b=XXmmAG0V1LfUsDaEAp0wOiYiX9 sLTuU4wUQkCaohjzKc4gzlX7fPR+Aj8vhVEyx5+H5YwQo8+nMf2sGQHPxEH53dvDUSTkaggrYlLeV n/IrZDwbEcZaMNLTbZi1UQ1sQ; Received: from 184-96-229-138.hlrn.qwest.net ([184.96.229.138]:50738 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jRys8-0026bn-Ea; Fri, 24 Apr 2020 08:00:04 -0600 From: Tom Tromey To: Shahab Vahedi via Gdb-patches Cc: Shahab Vahedi , Shahab Vahedi , Anton Kolesov , Francois Bedard Subject: Re: [PATCH 3/4] arc: Add GNU/Linux support for ARC References: <20200326125206.13120-1-shahab.vahedi@gmail.com> <20200326125206.13120-4-shahab.vahedi@gmail.com> X-Attribution: Tom Date: Fri, 24 Apr 2020 08:00:03 -0600 In-Reply-To: <20200326125206.13120-4-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Thu, 26 Mar 2020 13:52:05 +0100") Message-ID: <87o8rhdlwc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.229.138 X-Source-L: No X-Exim-ID: 1jRys8-0026bn-Ea X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-229-138.hlrn.qwest.net (murgatroyd) [184.96.229.138]:50738 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 14:00:07 -0000 >>>>> ">" == Shahab Vahedi via Gdb-patches writes: Thank you for the patch. I have a few nits to pick, but no serious issues. >> +static int >> +arc_linux_cannot_fetch_register (struct gdbarch *gdbarch, int regnum) >> +{ >> + /* Assume that register is readable if it is unknown. */ >> + switch (regnum) >> + { >> + case ARC_ILINK_REGNUM: >> + case ARC_RESERVED_REGNUM: >> + case ARC_LIMM_REGNUM: >> + return TRUE; gdb doesn't generally use the TRUE / FALSE defines -- there are exceptions, mostly for curses code, but on the whole these should be avoided. You can either use 1 / 0, or true / false. These functions only return int nowadays because C++-ification is incomplete and nobody has gone back to fix up gdbarch to use bool here, so I guess I'd opt for true / false. >> +/* Implement the "sw_breakpoint_from_kind" gdbarch method. */ >> + >> +static const gdb_byte * >> +arc_linux_sw_breakpoint_from_kind (struct gdbarch *gdbarch, int kind, int *size) This line is too long. >> +{ >> + >> + *size = kind; >> + return ((gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG) Spurious blank line at the start of this function. >> + /* Is this a delay slot? Then next PC is in BTA register. */ >> + if (status32 & ARC_STATUS32_DE_MASK) Normally in gdb this kind of expression is written out more fully, like: if ((status32 & ARC_STATUS32_DE_MASK) != 0) I thought GCC had a warning that prevented the form in the patch? Maybe I'm confusing it with something else. >> - /* Mask for DE bit is 0x40. */ >> - if (status32 & 0x40) >> + if (status32 & ARC_STATUS32_DE_MASK) As long as you're touching this, you might as well change it to the "!= 0" form. >> +arc*-*-linux*) >> + # Target: ARC machine running Linux >> + gdb_target_obs="arc-linux-tdep.o linux-tdep.o solib-svr4.o" >> + build_gdbserver=yes build_gdbserver is no longer needed in this file. Since gdbserver was moved to the top level, Whether or not gdbserver is built is now decided entirely by gdbserver/configure.srv. Tom