From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by sourceware.org (Postfix) with ESMTPS id 5E0043857C52 for ; Mon, 3 Aug 2020 15:52:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E0043857C52 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 073FRiL2096456; Mon, 3 Aug 2020 15:52:20 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 32pdnq2hgn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 03 Aug 2020 15:52:20 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 073FT3tZ188967; Mon, 3 Aug 2020 15:52:19 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 32p5gqx6f9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 Aug 2020 15:52:19 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 073FqI6I017152; Mon, 3 Aug 2020 15:52:18 GMT Received: from termi.oracle.com (/10.175.1.95) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 03 Aug 2020 08:52:18 -0700 From: "Jose E. Marchesi" To: "Aktemur, Tankut Baris" Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH V6 1/3] gdb: support for eBPF References: <20200803140237.14476-1-jose.marchesi@oracle.com> <20200803140237.14476-2-jose.marchesi@oracle.com> Date: Mon, 03 Aug 2020 17:52:15 +0200 In-Reply-To: (Tankut Baris Aktemur's message of "Mon, 3 Aug 2020 14:55:43 +0000") Message-ID: <87o8nrengw.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9702 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=924 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008030116 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9702 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 mlxscore=0 suspectscore=0 clxscore=1011 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=935 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008030116 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2020 15:52:28 -0000 Hello. > On Monday, August 3, 2020 4:03 PM, Jose E. Marchesi wrote: >> This patch adds basic support for the eBPF target: tdep and build >> machinery. The accompanying simulator is introduced in subsequent >> patches. >> >> +/* Internal debugging facilities. */ >> + >> +/* When this is set to non-zero debugging information will be >> + printed. */ >> + >> +static unsigned int bpf_debug_flag = 0; >> + >> +/* The show callback for 'show debug bpf'. */ >> + >> +static void >> +show_bpf_debug (struct ui_file *file, int from_tty, >> + struct cmd_list_element *c, const char *value) > > Just my two cents. The 'struct' keyword can be removed in numerous places > throughout the file. Also, NULL can be replaced with nullptr. I prefer to write (and maintain) C. >> +{ >> + fprintf_filtered (file, _("Debugging of BPF is %s.\n"), value); >> +} >> + >> + >> >> >> +/* BPF registers */ > > Might look better with dot-space-space at the end. Yeah, will add the missing dot-spacing in this and other instances you identified. Thanks for the feedback! :)