From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.122]) by sourceware.org (Postfix) with ESMTPS id A2B543986408 for ; Wed, 16 Sep 2020 13:42:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A2B543986408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id C1D6F13199 for ; Wed, 16 Sep 2020 08:42:19 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IXhTknkJeCjCVIXhTkOLeJ; Wed, 16 Sep 2020 08:42:19 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ju3P1MHJgv3s5HS5gfMwNufgZC0yDPGWEN8sfekv3to=; b=KsvgDq9Hb2uHZXT3bwa0ElA8t8 /DjlLwrZIeYKUEaPeGrjnoUpyFwmkhve5legVXjgOPLJEmHwbZ2JQL/Sq2nhm6lBJIg1EhO2CMtgs JxaWfeqtr+12bjI8QlFmZEpkJ; Received: from 75-166-96-88.hlrn.qwest.net ([75.166.96.88]:34650 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kIXhT-002QGz-5w; Wed, 16 Sep 2020 07:42:19 -0600 From: Tom Tromey To: Tankut Baris Aktemur via Gdb-patches Subject: Re: [PATCH] gdb/breakpoint: make a copy of the "commands" command's argument References: <1600248304-7656-1-git-send-email-tankut.baris.aktemur@intel.com> X-Attribution: Tom Date: Wed, 16 Sep 2020 07:42:17 -0600 In-Reply-To: <1600248304-7656-1-git-send-email-tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur via Gdb-patches's message of "Wed, 16 Sep 2020 11:25:04 +0200") Message-ID: <87o8m5aldy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.96.88 X-Source-L: No X-Exim-ID: 1kIXhT-002QGz-5w X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-96-88.hlrn.qwest.net (murgatroyd) [75.166.96.88]:34650 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 13:42:55 -0000 >>>>> "Tankut" == Tankut Baris Aktemur via Gdb-patches writes: Tankut> When GDB reads commands from the input, its internal buffer is re-used Tankut> for each line. I wonder if this could be changed instead. At least when reading from the user, a copy is already made. For instance, readline returns an allocated string. I recall thinking that this was hard for some reason, but I don't remember why any more :( Tankut> gdb/ChangeLog: Tankut> 2020-09-11 Tankut Baris Aktemur Tankut> * breakpoint.c (commands_command_1): Make a copy of the 'arg' Tankut> argument. This is ok. Thank you. Tom