From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XdPeHbrvImDkaAAAWB0awg (envelope-from ) for ; Tue, 09 Feb 2021 15:25:30 -0500 Received: by simark.ca (Postfix, from userid 112) id 6B9131EF4F; Tue, 9 Feb 2021 15:25:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 16CE11E590 for ; Tue, 9 Feb 2021 15:25:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 811A7385702F; Tue, 9 Feb 2021 20:25:29 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.216]) by sourceware.org (Postfix) with ESMTPS id 796A23857805 for ; Tue, 9 Feb 2021 20:25:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 796A23857805 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 65C07100F477 for ; Tue, 9 Feb 2021 14:25:01 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9ZZFlTNEDuDoA9ZZFlSXX3; Tue, 09 Feb 2021 14:25:01 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AstNHcPfYbU25ckdOw1qFlVCzHeoG0+Ax2IJuCbPCUw=; b=KJn0dxF9yyuNMs2RsswWF5xfay GXr+E3r9o+/zFTdI4mOMyMbIzSnB0LJX9bCrapSishj2wHxAmlUvhmM/DzZCm94PYNzbSeHAnsmKN c9xF9DdzUr/3Ya8FegOB7nEQY; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:43026 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9ZZE-001uJh-PO; Tue, 09 Feb 2021 13:25:00 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [PATCH][gdb/symtab] Fix element type modification in read_array_type References: <20210205122814.GA19232@delia> <87k0rm4gvn.fsf@tromey.com> <8b89b73a-205b-0da0-26fe-8d5e45a10886@suse.de> X-Attribution: Tom Date: Tue, 09 Feb 2021 13:24:59 -0700 In-Reply-To: <8b89b73a-205b-0da0-26fe-8d5e45a10886@suse.de> (Tom de Vries's message of "Sun, 7 Feb 2021 09:38:43 +0100") Message-ID: <87o8gtat0k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9ZZE-001uJh-PO X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:43026 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> + { Tom> + complaint (_("unable to handle array child DIE %s" Tom> + " - DIE at %s [in module %s]"), Tom> + dwarf_tag_name (child_die->tag), Tom> + sect_offset_str (die->sect_off), Tom> + objfile_name (cu->per_objfile->objfile)); Tom> + return NULL; Tom> + } This seems a bit too strong to me. A normal DWARF extension mechanism is to add new "unexpected" children to a DIE. In many (maybe most) cases, it's fine to just ignore these. Maybe another approach would be to bail out if range_types.empty(), issuing a complaint then. This wouldn't mention DW_TAG_generic_subrange, but that seems ok to me. Users don't really read complaints. Maybe even gdb developers don't ;) Tom