From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6rcJFgy1eWHTHQAAWB0awg (envelope-from ) for ; Wed, 27 Oct 2021 16:22:36 -0400 Received: by simark.ca (Postfix, from userid 112) id 510F01EE18; Wed, 27 Oct 2021 16:22:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AF9AC1E813 for ; Wed, 27 Oct 2021 16:22:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 690E93858439 for ; Wed, 27 Oct 2021 20:22:35 +0000 (GMT) Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.185.36]) by sourceware.org (Postfix) with ESMTPS id A6DEA3858003 for ; Wed, 27 Oct 2021 20:22:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6DEA3858003 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 3E9E2401BF717 for ; Wed, 27 Oct 2021 15:22:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fpRImzL41G0jLfpRIm48Yu; Wed, 27 Oct 2021 15:22:24 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=G+Z8I08ZYYDvd0afHzR2Tlx2crVtXfIIdrFUWR2CDEs=; b=RPNXg0HzXQ28d465Rjp+hA3cbF 4WEUCfQ5JKflj6s2qKEunhNdlKqLLx/TW0sgDEty9yRfgB6AAjR70rgNbA4a6EK5xiRDWuqPXZxc4 HYhq5SjQnkm98FgZlsU/VfKTO; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:54098 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mfpRH-000w3u-PE; Wed, 27 Oct 2021 14:22:23 -0600 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH 2/4] gdb: rename source_styling_changed observer References: <33d7cb45d4f4e7d99ef12dbbf2d1606d0aa27d32.1635241044.git.andrew.burgess@embecosm.com> X-Attribution: Tom Date: Wed, 27 Oct 2021 14:22:23 -0600 In-Reply-To: <33d7cb45d4f4e7d99ef12dbbf2d1606d0aa27d32.1635241044.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 26 Oct 2021 10:37:57 +0100") Message-ID: <87o87anrpc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mfpRH-000w3u-PE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:54098 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: Andrew> In the next commit I plan to add disassembler styling. In the same Andrew> way that we have a source_styling_changed observer I would need to add Andrew> a disassembler_styling_changed observer. Andrew> However, currently, these observers would only be notified from Andrew> cli-style.c:set_style_enabled, and observed in tui-winsource.c, Andrew> tui_source_window::style_changed, as a result, having two observers Andrew> seems unnecessary right now, so, in this commit, I plan to rename Andrew> source_styling_changed to just styling_changed, then, in the next Andrew> commit, I can use the same observer for both source styling, and Andrew> disassembler styling. Andrew> There should be no user visible changes after this commit. Looks good. It seems to me that the observable was misnamed all along. Tom