From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5A/hGg7NOWJ4TwAAWB0awg (envelope-from ) for ; Tue, 22 Mar 2022 09:20:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 582FC1F3C9; Tue, 22 Mar 2022 09:20:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D075C1EDF0 for ; Tue, 22 Mar 2022 09:20:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 295823945C30 for ; Tue, 22 Mar 2022 13:20:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 295823945C30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1647955213; bh=tLBlCTP3axCnyS2sfog354/gXJDgQSXmx7IzinGrm7w=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ThohuFM0FZ+aB+oBSQrlDfrA5xk2t+Ny0gICMOpwnzBn+y4AiBafZwmVKsY4n51DD RXpWTlRuxPryIwQ1an0jK/3GMCqEQT3VUPYJS5IZrFoc0tu0VPsUCMvZH1+dLXRHhG FFV5C1ecZ2yIPRvRX1TDyzdyF1g0J2L9eV8Sko1g= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 224133857C4A for ; Tue, 22 Mar 2022 13:19:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 224133857C4A Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-175-4I_Z8hTVO7qi9czMdlhupg-1; Tue, 22 Mar 2022 09:19:53 -0400 X-MC-Unique: 4I_Z8hTVO7qi9czMdlhupg-1 Received: by mail-wm1-f69.google.com with SMTP id m123-20020a1c2681000000b0038c9e1197f6so2678836wmm.4 for ; Tue, 22 Mar 2022 06:19:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=tLBlCTP3axCnyS2sfog354/gXJDgQSXmx7IzinGrm7w=; b=XnIbBQl6p4BJhiYix4lCpRfg4hfJyKd+BApEneFpwEH4GVKVMRM6fF53637FBgp7Dv oBXFER+Rpr8HzqjJSc6BBgM/jl4aLzECBcV+QvSz4CQiUI7fIdRxGmdh0lZ2lJzP8AGx jDAlIoQFCw9K5+0otZkIgqsNNIyTIvf3q6GdpI41JPBDdNg0DHvTSJjrnVqUlreNRGon JyTpJs/VOJwdeJV9srQyO3o5kK+r7vMxSPUX/VnM33/gXfc4PcgTri0IcVTmoOkuINUA c3frjebJfOxMzfdLktXPighuRCSCrNAyROYAP2jOZDc+5NuCEEY1vMWiQC0wkkSC7GTx Mgvw== X-Gm-Message-State: AOAM5332KyMRvsTnqp2p2KfytlX8VudtNB2u0Vnxhym+vcSeMUxmn421 Rxga+mkajjdc42HnseKid+hFozg4mvrlUv+7FoE6yM9ib7fwXNWjbK1lt7XnczB0NqOZbPHBBTb 4uzq0S/mC2fTN15vpicDk6g== X-Received: by 2002:a05:600c:4e92:b0:38c:73e8:7dcd with SMTP id f18-20020a05600c4e9200b0038c73e87dcdmr3924152wmq.196.1647955192042; Tue, 22 Mar 2022 06:19:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgriYeN+kmsl6l2a1Xuo6/TrefVVZjRkik2fDiRoDv+JBgw9xKiJLWisx7U6bioy3O7BzpGw== X-Received: by 2002:a05:600c:4e92:b0:38c:73e8:7dcd with SMTP id f18-20020a05600c4e9200b0038c73e87dcdmr3924130wmq.196.1647955191865; Tue, 22 Mar 2022 06:19:51 -0700 (PDT) Received: from localhost (host109-158-45-15.range109-158.btcentralplus.com. [109.158.45.15]) by smtp.gmail.com with ESMTPSA id n18-20020a5d6612000000b00203fbd39059sm9556028wru.42.2022.03.22.06.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 06:19:51 -0700 (PDT) To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCHv3] gdb/python: add gdb.format_address function In-Reply-To: References: <20220304105031.2706582-1-aburgess@redhat.com> <20220307123317.3966024-1-aburgess@redhat.com> Date: Tue, 22 Mar 2022 13:19:50 +0000 Message-ID: <87o81yruo9.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Simon Marchi via Gdb-patches writes: >> diff --git a/gdb/python/py-arch.c b/gdb/python/py-arch.c >> index 0f273b344e4..53906ce506e 100644 >> --- a/gdb/python/py-arch.c >> +++ b/gdb/python/py-arch.c >> @@ -62,16 +62,25 @@ arch_object_data_init (struct gdbarch *gdbarch) >> } >> >> /* Returns the struct gdbarch value corresponding to the given Python >> - architecture object OBJ. */ >> + architecture object OBJ, which must be a gdb.Architecture object. */ >> >> struct gdbarch * >> arch_object_to_gdbarch (PyObject *obj) >> { >> - arch_object *py_arch = (arch_object *) obj; >> + gdb_assert (PyObject_TypeCheck (obj, &arch_object_type)); > > Since we have a function for that, I'd do: > > gdb_assert (gdbpy_is_architecture (obj)); > >> diff --git a/gdb/python/py-progspace.c b/gdb/python/py-progspace.c >> index 1e01068c59b..f9f2a969e2b 100644 >> --- a/gdb/python/py-progspace.c >> +++ b/gdb/python/py-progspace.c >> @@ -504,6 +504,23 @@ pspace_to_pspace_object (struct program_space *pspace) >> return gdbpy_ref<>::new_reference (result); >> } >> >> +/* See python-internal.h. */ >> + >> +struct program_space * >> +progspace_object_to_program_space (PyObject *obj) >> +{ >> + gdb_assert (PyObject_TypeCheck (obj, &pspace_object_type)); > > Same here, use gdbpy_is_progspace. > > Otherwise, LGTM. Thanks, I made those changes and pushed this patch. Andrew