From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id keCXIWaSLWUJnS8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 15:43:34 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=xFTBwVfK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7F03A1E0C1; Mon, 16 Oct 2023 15:43:34 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C71A1E091 for ; Mon, 16 Oct 2023 15:43:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E30C385840B for ; Mon, 16 Oct 2023 19:43:31 +0000 (GMT) Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 86CFD3858C66 for ; Mon, 16 Oct 2023 19:43:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86CFD3858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86CFD3858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697485400; cv=none; b=pUpqYadQ6r5tfj7jKMuBnY5r90xpNHRqdJCLD0yuuyK/wRqk/ksrpevT894xXgiOibevksO8boSnWjETpXedercHSdbFDly6gOue5px++XJZNG5R1QRWQcRZcWBTpGNnLSc1/OhoDDA00aN3pljFmj0CIBYiyjTSyLqwv5DLFQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697485400; c=relaxed/simple; bh=VjGN+IwtOOnK8bpQN/qawjxmrUCcIKuZ6AuIuQII0Iw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OLGBo0CwXmsg6dATco949WTXOinbEQkg55pFTUhYURMV4A0n4r9niIJQFMZeIRX6JWkSXr4H/qFuawrRKo4QhRn/p9V+ngsXCyTqc215twdFmdiP5TfefduU0ZB82TaEHGKMHDprKfl6oajJnwryRDV6jHLOrX1X+nEKOE13Yzk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTP id sLboqZA6GIBlVsTUGqnZCH; Mon, 16 Oct 2023 19:42:49 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id sTUjqm25fIzZksTUjq5X4L; Mon, 16 Oct 2023 19:43:17 +0000 X-Authority-Analysis: v=2.4 cv=ZdYOi+ZA c=1 sm=1 tr=0 ts=652d9255 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=zd2uoN0lAAAA:8 a=zstS-IiYAAAA:8 a=FpLfitrpUeptu59Z9boA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=F1hAzCpndmQK4D4kGzkj7o2jZOWlTJt97AsJpr8jnJA=; b=xFTBwVfKMuKw7SjNh9XWz2/mvy VLdNDFDS1ABe/iS8irRtuJGNFLNJu8HV/XhQH1+lSiWmJvuoyYrB6sN5TIW+OsPj0ZcNtvCPxbk7P 44O0DmPhP9rrQPGrXa29pn3+x; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:38876 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qsTUi-001Jmz-2m; Mon, 16 Oct 2023 13:43:16 -0600 From: Tom Tromey To: Lancelot Six Cc: Subject: Re: [PATCH 00/11] GDB: Require C++17 References: <20231013144418.3180617-1-lancelot.six@amd.com> X-Attribution: Tom Date: Mon, 16 Oct 2023 13:43:15 -0600 In-Reply-To: <20231013144418.3180617-1-lancelot.six@amd.com> (Lancelot Six's message of "Fri, 13 Oct 2023 14:44:07 +0000") Message-ID: <87o7gyqros.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qsTUi-001Jmz-2m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:38876 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHjv0G7t7iFP3xdrBhqdpBV367V02BT3AZ3LDA1kJZSRRFqSmcuLYls0UABO+UJyogQlBtw5u1LhEUkjkg4oZtywFJ0vOlwQ6IDrLeVhlEkuxuJLA2T8 TyW3L+vFV7vOe7KMWKg6eXC5TetCK6/F3JB6zr+fU5LxCF++E4h/G7LIMxM5IroAL7/sGcatFi9Y2W4SGTl/dKmJIyznNDl8qDw= X-Spam-Status: No, score=-3018.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Lancelot" == Lancelot Six writes: Lancelot> This series is a followup of the discussions from last Cauldron and Tom's Lancelot> RFC patch[1] regarding requiring C++17 in GDB. It seems that the Lancelot> overall sentiment is positive for such move, so here is a proper series. Hi. I've sent a few minor comments, but otherwise everything looks good to me. Thank you for doing this. Approved-By: Tom Tromey I'm giving my approval but this should probably wait a little for others to comment as well. FWIW I have a follow-up series I'll send after testing is done. I found a number of other fairly straightforward C++17 changes. Tom