From: Tom Tromey <tom@tromey.com>
To: Carl Love <cel@linux.ibm.com>
Cc: Luis Machado <luis.machado@arm.com>,
gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>,
Guinevere Larsen <blarsen@redhat.com>,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: Re: [PATCH ver 2] Fix the gdb.ada/inline-section-gc.exp test
Date: Wed, 08 Nov 2023 09:54:45 -0700 [thread overview]
Message-ID: <87o7g4rxre.fsf@tromey.com> (raw)
In-Reply-To: <dd151c7ffffbc9b17cef32225d8de9d6a4b93c89.camel@linux.ibm.com> (Carl Love's message of "Wed, 08 Nov 2023 08:22:43 -0800")
>>>>> "Carl" == Carl Love <cel@linux.ibm.com> writes:
Carl> GDB maintainers, Luis, Tom:
Carl> Version 2, fixed the name of the test the patch fixes in the email.
Carl> Mixed it up with another patch I am working on sorry about that.
No worries.
Carl> Here is the patch to fix test gdb.ada/inline-section-gc.exp on
Carl> PowerPC as discussed on IRC.
I think it looks good, but I have one nit.
Carl> +set bp_location1 [gdb_get_line_number "BREAK" ${testdir}/callee.adb]
Carl> +set bp_location2 [expr $bp_location1 - 1]
It would be better to just stick some comment on the relevant line in
caller.adb and then use gdb_get_line_number to fetch it.
thanks,
Tom
next prev parent reply other threads:[~2023-11-08 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 16:22 Carl Love
2023-11-08 16:54 ` Tom Tromey [this message]
2023-11-08 16:57 ` Luis Machado
2023-11-08 18:02 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7g4rxre.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=blarsen@redhat.com \
--cc=cel@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox