From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5JKiOmacnWX8ADcAWB0awg (envelope-from ) for ; Tue, 09 Jan 2024 14:20:06 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=DNyUJwmz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DEE2E1E0C3; Tue, 9 Jan 2024 14:20:06 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CC4C01E0B9 for ; Tue, 9 Jan 2024 14:20:04 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 581023858422 for ; Tue, 9 Jan 2024 19:20:04 +0000 (GMT) Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 30A6B3858407 for ; Tue, 9 Jan 2024 19:19:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30A6B3858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 30A6B3858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704827987; cv=none; b=t1m014Pz7jY+5ladTn/BqMAWGzbi0TYBf4G9q2CCHk8UeBssdaD0jv0UszZBejaOfNsga1m4VKrrwsE+ZpEutzhw790WBtBFyKQyGfTv4e6o3e3DzS0OYaHwmixfXGkf+H3+jFF2QwJszjqXQnuRDhv2Ax34z+bFCibDGYKEPvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704827987; c=relaxed/simple; bh=Kn46ICb5pIf8JJZYcjpBaKez/h7TxYb3dloPfaenV8c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Sh7qBjMPEsBfuETHwq6JjXWwiuNdz60pWQGgH7TKU6DV9dQw1k7wS1HOd5tCYNSV+EtYgv4tZqszrKQFOeOy16HJD3A37DFBKkIQMeSOysVrtLbVegvAykmYwLSVA73DlXw9N4ErAi8DYDp+Iw3e5m4TN7W2HGK1efZkAYHpOmE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id N65lrM7d8CF6GNHdZrV0PV; Tue, 09 Jan 2024 19:19:45 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NHdXrRzo3l5UwNHdYrvTkA; Tue, 09 Jan 2024 19:19:44 +0000 X-Authority-Analysis: v=2.4 cv=daKTYFbe c=1 sm=1 tr=0 ts=659d9c50 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=xOWLnXvRZivCAlid9AAA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nLySsZ5ZC2AdWMr/4Hlofl5DPn9lDRi/0KQ9xkjbpso=; b=DNyUJwmzeMtU5yc0aCiJx240X0 EYwhrHaTAGFu/FGgK2TemqaG762yFnrX5ZD47ui88N0gYuYEnvbr5hi8CyVyyonS4/MWA9Catvmb5 N/Zco67uQ+aLoGyaPyEQJSnjN; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:57774 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rNHdX-0029lX-1n; Tue, 09 Jan 2024 12:19:43 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] gdb/python: hoist common invalid object repr code into py-utils.c References: <791370ed269cee0ce3dc30f0a01307c00473878a.1704455158.git.aburgess@redhat.com> X-Attribution: Tom Date: Tue, 09 Jan 2024 12:19:42 -0700 In-Reply-To: <791370ed269cee0ce3dc30f0a01307c00473878a.1704455158.git.aburgess@redhat.com> (Andrew Burgess's message of "Fri, 5 Jan 2024 11:48:30 +0000") Message-ID: <87o7dutiup.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rNHdX-0029lX-1n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:57774 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOpNpVsl78Eq9smS+0fDQUactyV7Rgp4pXnfXOzxhwZ25QZVn33D8ypTOk5vkVXsRpxjTFBLCvCMgNw03szFmUeIBQuIt7XVYjdtIU12aofT1zxEnH/6 Z77T9sf8yk6XsxoaBGnVaMUKcPenCWBN+P/o3fMprSE800W+X2K1g6sFYxHFigGK4HlxcG8RRLyH9b94a1weFLUa0Xdb/+Hl8tw= X-Spam-Status: No, score=-3016.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> The only place where I haven't made use of the new function is in Andrew> unwind_infopy_repr, where we currently return a different string. Andrew> This case is a little different as the UnwindInfo is invalid because Andrew> it references a frame, and it is the frame itself which is invalid. Andrew> That said, I think it would be fine to switch to using the standard Andrew> format; if the UnwindInfo references an invalid frame, then the Andrew> UnwindInfo is itself invalid. But changing this would be an actual Andrew> change in behaviour, while all the other changes in this commit are Andrew> just refactoring. I think this patch is fine as-is, but FWIW I don't think we need to worry about code that relies on the precise content of the repr of an invalid object. IOW, I think it's fine to change unwind_infopy_repr as well. Tom