From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Y6K1Aq4UFmf5kBUAWB0awg (envelope-from ) for ; Mon, 21 Oct 2024 04:45:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fGayxbh8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E2C581E360; Mon, 21 Oct 2024 04:45:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C2D041E091 for ; Mon, 21 Oct 2024 04:45:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 245DB385840A for ; Mon, 21 Oct 2024 08:45:32 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 3DED63858C98 for ; Mon, 21 Oct 2024 08:45:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DED63858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3DED63858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729500315; cv=none; b=AX7iEqacYC7kUgZT0QF+7EltCuT2wq2hT5Oa8+DGrml8n0L0X/bBsl61X1JKsvw1YSAr71R3Fy2Qgx4gzY7xtq91u9LlNUPASy7zluNKPzTozDptD7ApdPFqLNmj1rQlhIhD5Zah2sugc1vz887h9GN57QXxa8NmwH7ag72O84Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729500315; c=relaxed/simple; bh=ewBHKBMIApRq0u4iC8wCxu9bdyAIWTApwwkQgyO6cgM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TMfI2jqcfIsq6/DQRiBarlDxQlqPgfj8QxNBfKO74Xn0Y/w4gqOWRswT7Ysgpoy4l8iX008YVw75bfiX7H4I0E1UKtHK4bUQQSJc8VPISJyV/GILuBKZKNMq3ZO+xVgr5eIvhKKgtBM+2kS8V4uchjBvy3OEyJfSbsO9+fC4czM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729500310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CTeINAuGA3MWPVIhCgT143OTNCZcE19Gz1/NrfEzrNw=; b=fGayxbh8H1ijbbRk4z0GV3Ilq0ZEM10tpWL+zDaLzmqOZ/rNdFGX8j7Oz2dlyxEOILCvuV c+X+9L0LHI2ZzeNmQBaBA5NJys3sVsHpb/GZfzo9joAALtzUDysY+MD0TE3SxA2a3cBuNm Q41x5i+NZESvlfoLw4iahqX0byqvfTI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-a1TgmzzSN2q7E0uEOwxegQ-1; Mon, 21 Oct 2024 04:45:08 -0400 X-MC-Unique: a1TgmzzSN2q7E0uEOwxegQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d5a3afa84so2177747f8f.3 for ; Mon, 21 Oct 2024 01:45:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729500307; x=1730105107; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CTeINAuGA3MWPVIhCgT143OTNCZcE19Gz1/NrfEzrNw=; b=kYUXuIB453p1/eqtbtiRIPlBpwuGtle2MBQ3OUaelrwyswdrb8KGm3fnVWMw5KOkH3 lkwegnfQ17otwFdd2mRbSQplpKdr6Qx/fftDT4SDnYn1rNRyrKlwqbq8sClFn2Z8fqGQ ltm00kZOdEYiuvcixT7Lioq0WlrUumCyWLnc0tA2BNIlnltOXvSnA1uJG/jXk2eXaLIC ARUqiNv10niav28UMHK2JfDgt4nNFeBg+UrGKfWO7YzUsChLtjTdHaj/b38UFemFlhLy 70EYRxSIwP9hxy+6O+JW+UZ8hOUVS9lHfxK/cC06uncw8kZPDLRsMuxU/wIaceQ+mpVM iqNg== X-Forwarded-Encrypted: i=1; AJvYcCV/G+3belRNpBUuTphdWjEhSdS6eog3cb3xIjnn43es32w3sEhUpHL8xpVzfg7DbKcmaHI08/xJUFN+PA==@sourceware.org X-Gm-Message-State: AOJu0Yzdida72C8GeHAJKg8o8jX0WhwQqvd+1Oa03dhc+X3Qkesa309/ wEOCMX3hK72qgAE87iayp5JwMYtTIm2Xpq3pozJRHg27Xj7xXTpPShU3sWynrIxXKWqOCNhrE5c nbbDaXUk4gPwpfANG9VJi2ytHZPvZok6MRnZtYVTgQN5gm7jz7mrI04MgU/M= X-Received: by 2002:a5d:58d2:0:b0:374:ca16:e09b with SMTP id ffacd0b85a97d-37ea21370eamr6850546f8f.9.1729500307616; Mon, 21 Oct 2024 01:45:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfd+adUzbL69I7a/oPxhLt9dk03wsKdeasaA8WzcPK5uEY24+ZqUDZnW2Y/eMH6QUcSPPzbA== X-Received: by 2002:a5d:58d2:0:b0:374:ca16:e09b with SMTP id ffacd0b85a97d-37ea21370eamr6850538f8f.9.1729500307179; Mon, 21 Oct 2024 01:45:07 -0700 (PDT) Received: from localhost ([195.213.152.26]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f5c2df7sm49402595e9.33.2024.10.21.01.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 01:45:06 -0700 (PDT) From: Andrew Burgess To: Markus Metzger , gdb-patches@sourceware.org Cc: pedro@palves.net Subject: Re: [PATCH v5 0/4] PR gdb/31353 In-Reply-To: <20240410074613.54520-1-markus.t.metzger@intel.com> References: <20240410074613.54520-1-markus.t.metzger@intel.com> Date: Mon, 21 Oct 2024 09:45:05 +0100 Message-ID: <87o73dyhda.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Markus Metzger writes: > Reviving an old patch series that was first submitted in Jan'21. > > It fixes issues with breakpoints at the end of the execution history, > including PR gdb/31353, which was submitted in the meantime. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31353 You should include this 'Bug: ...' tag at the bottom of every commit message for commits that relate to this bug. Do 'git log' and search for 'Bug:' if I've not been clear what I mean. No need to repost with this change, I'm going to have a read through the rest of the series this week. Thanks, Andrew > > Guinevere Larsen reviewed most of the series and reported an issue with > applying the last patch. I'm resending the series, rebased on current > master, to hopefully fix that issue. > > The only change to v4 is that a redundant forward declaration was removed. > > The changes are mostly in infrun and require global maintainer approval. > > Markus Metzger (4): > gdb, infrun, btrace: fix reverse/replay stepping at end of execution > history > gdb, infrun, record: fix hang when step-over fails with no-history > gdb, infrun, record: move no-history notification into normal_stop > gdb, infrun: fix multi-threaded reverse stepping > > gdb/gdbthread.h | 13 +++ > gdb/infrun.c | 86 +++++++++++++----- > gdb/infrun.h | 7 -- > gdb/record-btrace.c | 19 ++-- > gdb/testsuite/gdb.btrace/cont-hang.exp | 43 +++++++++ > .../gdb.btrace/implicit-stop-replaying.exp | 90 +++++++++++++++++++ > .../gdb.btrace/multi-thread-break-hang.exp | 84 +++++++++++++++++ > gdb/testsuite/gdb.btrace/step-hang.exp | 42 +++++++++ > gdb/testsuite/gdb.btrace/stepn.exp | 50 +++++++++++ > 9 files changed, 398 insertions(+), 36 deletions(-) > create mode 100644 gdb/testsuite/gdb.btrace/cont-hang.exp > create mode 100644 gdb/testsuite/gdb.btrace/implicit-stop-replaying.exp > create mode 100644 gdb/testsuite/gdb.btrace/multi-thread-break-hang.exp > create mode 100644 gdb/testsuite/gdb.btrace/step-hang.exp > create mode 100644 gdb/testsuite/gdb.btrace/stepn.exp > > -- > 2.34.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928