From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MQBWKfd+v2j/jDwAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 21:12:23 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=OszQT2qJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A50361E0BA; Mon, 08 Sep 2025 21:12:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F88D1E047 for ; Mon, 08 Sep 2025 21:12:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 690573858C5E for ; Tue, 9 Sep 2025 01:12:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 690573858C5E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=OszQT2qJ Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id C6F813858D1E for ; Tue, 9 Sep 2025 01:11:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6F813858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6F813858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757380304; cv=none; b=SFRpDb/QBJ1SkMcRE1li3Ei/xounYF6Y0tfKrXB4TpS2xM9+MXoNYvAmZvPNFKSCG/OYJXVeyAW3McsyvX/M0lC0g5f+bbKYN7kzPUS+rtAhwhMVbbvlEZ7eAW1V1bZ8pCx7eBDLz8vNiTLv4bhLV3I3n9wv5ZIHplieQepXwik= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757380304; c=relaxed/simple; bh=sInEvSTbZvZYM5jpvYmM29sI9Ul3wi0sH1eWJDHO2Qo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lQxJGfLXj2Nk50Vx06/UUfn31Xnp38v0TK47sNjpWIz9y5Nffo1nEw4S/ttZWt54+nrvTIximrxltPlMttkfarKvVg7jWsds/qOg8TvnQYTjWrjUHLKa2ncvxdfzL1/pcDNjMulnqn+ispVL2GaaEwAje0uaAyDTSKfcM+JqT0Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C6F813858D1E Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id ve9suiR9Ajzfwvmtau4CVg; Tue, 09 Sep 2025 01:11:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id vmtauZvNxEzdIvmtauY7sh; Tue, 09 Sep 2025 01:11:42 +0000 X-Authority-Analysis: v=2.4 cv=D9ZHKuRj c=1 sm=1 tr=0 ts=68bf7ece a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=6Wo-TegjKsH16o_6mFMA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PYlspYMsYLRrzAGd7e8aWievq/HgLsunapQg+sqW+UU=; b=OszQT2qJ2V1NVuA4Dhk/Gjl+Tj SmAporU9RKcU/W2m6h/Z6BUH8hq7LOb/jEA+71E4HX8qJb20UfxEvOndp6dPfmhZ0mUxA/OxWJFg0 DdiIiBNRbUBELycCWYiHCw+Os; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:52804 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uvmtZ-000000016i1-35tn; Mon, 08 Sep 2025 19:11:41 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] Boolify line-program.c In-Reply-To: <09056576-0c5b-4d55-b016-583e5e05c57e@simark.ca> (Simon Marchi's message of "Mon, 8 Sep 2025 20:50:25 -0400") References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-3-dd2beef9d475@tromey.com> <445303b8-f7e3-47f8-a67b-588ad3a13a6f@simark.ca> <871pogih7j.fsf@tromey.com> <09056576-0c5b-4d55-b016-583e5e05c57e@simark.ca> X-Attribution: Tom Date: Mon, 08 Sep 2025 19:11:39 -0600 Message-ID: <87o6rkh1kk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uvmtZ-000000016i1-35tn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (prentzel) [97.122.110.68]:52804 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMvW5dIUEmEzSmYHTTM0DvqeGtfSAIkI08ZI+xRNVJBm6EO+BKjM4P0qx8SUnfKC22CHsacWv6TNstPx8VUQDKeBwOmdCctLHTmQ0mW/kLAlw7jsdB8Y JLk+ChDyaTIoUi55+PUiAtJKs10ZcRLIyAFSUGer1WOOVRlvRXrbeyyzb07FI3LmdG9829AjoOxIAFuqTajs7DE1qwToZ8jBVW0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> I fixed the appended but the comment in the header looks correct to me? >> Anyway if you can point out what is wrong I will fix it. Simon> The actual intro comment should be in the header, with the usual Simon> /* See ... */ Simon> in the source file. It looks like the comments diverged a bit, when Simon> that happens I try to pick the best of both. For instance, it looks Simon> like the comment in the header doesn't have the "Return non-zero if..." Simon> part. I pushed this already but I will look at it again & fix it tomorrow. Tom