From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iMOkE4PwxWi8VQMAWB0awg (envelope-from ) for ; Sat, 13 Sep 2025 18:30:27 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ul4wFc0W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3C91D1E047; Sat, 13 Sep 2025 18:30:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 723D01E047 for ; Sat, 13 Sep 2025 18:30:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 01DD73858C50 for ; Sat, 13 Sep 2025 22:30:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 01DD73858C50 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ul4wFc0W Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id F1C943858D21 for ; Sat, 13 Sep 2025 22:29:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1C943858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1C943858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757802595; cv=none; b=t6MVTHoYOCV66Y6rqrAc87CzWf4dUkHYbel7e487cHsvsPpPrssyhm5x9Hpm8eHu0K/u9SfeoRHbBPzsKyM43WAuFsuiCszO20kYwSF9TGffcYPU9CsYUM4JABcO9bPBbjT0UAeDxN4Ahruvi74JkqBF//fD41hSbRwKiGcPhr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757802595; c=relaxed/simple; bh=8sBO5VRSchz4dF38eqcu0PEnlrG59yff2Cjl+aSraCE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BN5FCBi7ALTk2+OcxugMjIpiJxo8CCuJokG0rFEDxSEgiz9t3MilnIGFCteL+HVVUyyquILzbmMB/rBfFHDk7cswni1wpfgZnLh93MdR5k4H6MrCGDglrVOL2mLdYVEWxVofR/4xqTRqgxfB3wh8TTO2mpd7hfKjxAtPxkjJTHQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F1C943858D21 Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id xXLnug2VHeNqixYkju0mOy; Sat, 13 Sep 2025 22:29:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xYkiuatU0cL7DxYkjuom3l; Sat, 13 Sep 2025 22:29:53 +0000 X-Authority-Analysis: v=2.4 cv=Xqb6OUF9 c=1 sm=1 tr=0 ts=68c5f061 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=8IMVErROLsNcEghzHfAA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rzmsiGu/MNOInmw0OO4paDN7X5+r8pWeS65CsV4PF3A=; b=ul4wFc0W1HNWP2ac3q+yiDn0sb ePpmaVxT2RkOBHaj5KlbLywcQ8i685iXnszx+cz4G6qfA7lt7GaBF8ZXgXGkqpxA+sokSHkVqdajG wG2ikzkdBgR9K+Pnmb4MMsaXH; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:59310 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uxYki-00000002Trq-2Wls; Sat, 13 Sep 2025 16:29:52 -0600 From: Tom Tromey To: Kevin Buettner Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Fix crash in f-typeprint.c In-Reply-To: <20250913144716.5ecd1209@f41-zbm-amd> (Kevin Buettner's message of "Sat, 13 Sep 2025 14:48:23 -0700") References: <20250913194811.933550-1-tom@tromey.com> <20250913144716.5ecd1209@f41-zbm-amd> X-Attribution: Tom Date: Sat, 13 Sep 2025 16:29:41 -0600 Message-ID: <87o6ref0kq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uxYki-00000002Trq-2Wls X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (prentzel) [97.122.110.68]:59310 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEyoylTMHTEHAiA0G8LyEXkvZggMtCN+v+eKKjGj8u1I2IgAt3zjpHsKlsPcn8j/O1K5iGeP8WLnWfEsrM9/RstgzVOK518UMpK5aOHeTeJDVJ7Z9vP7 iCGhjIZcBV1HvclLRvyWY6DgjzfMHq5qH0Wf8SwiHh1bTzt4Aevd5QzbZk3rAQPSiLCK8OTEpgwGozTvT/5uQ58ksMcbu+9f4jQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Kevin" == Kevin Buettner writes: >> gdb_puts (" ", stream); >> >> - gdb_puts (type->name (), stream); >> + if (type->name () != nullptr) >> + gdb_puts (type->name (), stream); Kevin> If you can't print the type, I'm wondering if it makes sense to print Kevin> the space before it? (I.e. look at the gdb_puts a few lines above...) I don't know but this change does preserve what happened before the change to gdb_puts. Tom