From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tU+UK0gq4GhkFR4AWB0awg (envelope-from ) for ; Fri, 03 Oct 2025 15:55:52 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jlsE7BfS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 91B651E0B6; Fri, 03 Oct 2025 15:55:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 28CA71E04C for ; Fri, 03 Oct 2025 15:55:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B648C385772F for ; Fri, 3 Oct 2025 19:55:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B648C385772F Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jlsE7BfS Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 10EC43857B9E for ; Fri, 3 Oct 2025 19:55:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10EC43857B9E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 10EC43857B9E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759521305; cv=none; b=lLPE2t9kOjCMd2zyznetek6XYYySTKOwdu6/cN6Ubfx6RTzGeTkwY8Q31Q7NERZ5uh0qCUX7MrFn8UnGgMnQoFpeqxqCDmzjFlgZgVmsxv72TNupeop5g2+XDaoccIYqh8sdGjODFAAJ7mDC+W8C/zSr4OP/UibrnEEQ30vovus= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759521305; c=relaxed/simple; bh=6vHqxeGxpEfjgeEwKOXnhkAQ74WCWDr8l1l+1eLGXUA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=clD4Vmeo6hbgXpkmRZP15JcBo96ExEWBtXl6Ss+qMm3CBBpd1jhr31BG8UWS9rZaTqC6EHcAfHO4ja+Cwo585vaqVgljG5S9Glpt7cY+OIEVA5KY1h+NgxvuKO+AG9pb+o6RCo25+zGOfpOU5vdg4LmUzGnhaEt7bDK/2XqsPfM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10EC43857B9E Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id 4QsXvj8ZAeNqi4lrsvVYKX; Fri, 03 Oct 2025 19:55:04 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4lrrvm2akfjrX4lrrvfue4; Fri, 03 Oct 2025 19:55:04 +0000 X-Authority-Analysis: v=2.4 cv=ItcecK/g c=1 sm=1 tr=0 ts=68e02a18 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=sqeRbNfJ8Sy4EakEk_0A:9 a=zZCYzV9kfG8A:10 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TspKsxcaJwALFNRJDS4/5/zRu4QZhJIt6pCix79GXik=; b=jlsE7BfSK5J9ESicznIJjklWgg JjmkHPvMIGLdPiRMc8S5LLBmrrlcXylrvXDC4E3u09nDMMPqud42Fc6Mn6+4ySE3SDi0ndIm1fliK ttXzH4MLvSDZuxdx9+RaZuDua; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:41954 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v4lrr-00000000x5G-10Wt; Fri, 03 Oct 2025 13:55:03 -0600 From: Tom Tromey To: Christina Schimpe Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/9] gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c. In-Reply-To: <20250923111842.4091694-5-christina.schimpe@intel.com> (Christina Schimpe's message of "Tue, 23 Sep 2025 11:18:37 +0000") References: <20250923111842.4091694-1-christina.schimpe@intel.com> <20250923111842.4091694-5-christina.schimpe@intel.com> X-Attribution: Tom Date: Fri, 03 Oct 2025 13:55:02 -0600 Message-ID: <87o6qn69rd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1v4lrr-00000000x5G-10Wt X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:41954 X-Source-Auth: tom+tromey.com X-Email-Count: 22 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKa0atUMXHlDUMsJCrDFL+dKYMf3J+75/VrB9Kdt48tzZWmt9whtZ0sNQq7QX3a1vHNMRybO+JYQbRc5XDnHXZyX3JjSsdc9PEAapJMBUqykSzqrvIvm xMUnCkJ8NL4MMOphTYmzpC8dSVcAsdmHP2tusKEV6A3uiG+VM5eAo5XAr7g5peNb4IwtkJ9/nKyXdR1PSOWcu+cE35Kpl+5Xss0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Christina Schimpe writes: > To avoid code duplication, create a new function 'stack.c:find_symbol_funname', > which will be used in 'stack.c:find_frame_funname' and > 'stack.c:info_frame_command_core'. > The function will also be used in a following commit. Thanks. > + if (funname == nullptr) > + { > + /* If we didn't hit the C++ case above, set *funname here. */ > + funname.reset (xstrdup (print_name)); This should use make_unique_xstrdup and plain assignment. > + funname.reset (xstrdup (msymbol.minsym->print_name ())); Here too. Tom