From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yTHBDTIIFmnIKz4AWB0awg (envelope-from ) for ; Thu, 13 Nov 2025 11:32:50 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PO0vWkbA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 355E51E057; Thu, 13 Nov 2025 11:32:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ABFF81E057 for ; Thu, 13 Nov 2025 11:32:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E7C4385841C for ; Thu, 13 Nov 2025 16:32:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4E7C4385841C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PO0vWkbA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7505D3858D20 for ; Thu, 13 Nov 2025 16:32:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7505D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7505D3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763051529; cv=none; b=KcdzjSTsHSE61SGpyTDLtifFfj7P0qnZLc4tkbXlKEWyRRvYeMAH33abhDeFPNqVqMzUiUufphgDr9VfL26vlCzqjssfe0g2DhQkht9BFSOfFRn7pnDPyOFEFXnJgKuUFrprOJHWc00Rp/vnzh4c8A17dQC8W5GjU/cI1b8b/ZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763051529; c=relaxed/simple; bh=6eHzCYUYm2AzL96DHJLCYZlxoRByxC/4CmcbQbVWGbo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WaMqITTuzNyqJLd8jWa7Mh5YFv/LsQ/ZuhFiPdtPUCvhlms2mRGPexeuhjq8mP06AZlbuWpE7ONmjtx3w6AKNp4cYhkaez7hafOpM6I3WIx1KF/d7zpPoUQ9Q1NeOv/Kb7kGu6IH1snzO80c6/Xh0lWLMDw5VPh28ILCZgFb4EM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7505D3858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763051529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=27ZF324hUpOB/i2NN5yTUOxV4nVg2Y2t4pz/2MUe4vU=; b=PO0vWkbADQw10lWhiCvCkbvqGtjAn8BAcw+1bZlNmm2WUTdgBifwFfFPDJA6BfNbdNVAlZ DKcLZQHkx9LOazlOBnG1u8bBT282d8hf+hwcnMJzUUCyLnZeTCLBba2iFSbmYg+sXQae1x B0OcDVA6zpkcfAPP0ePFK41SKyoXVk8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-bsGViK3NMeOsmZk-ZYAKng-1; Thu, 13 Nov 2025 11:32:07 -0500 X-MC-Unique: bsGViK3NMeOsmZk-ZYAKng-1 X-Mimecast-MFC-AGG-ID: bsGViK3NMeOsmZk-ZYAKng_1763051526 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47111dc7c5dso5729075e9.0 for ; Thu, 13 Nov 2025 08:32:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763051526; x=1763656326; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=27ZF324hUpOB/i2NN5yTUOxV4nVg2Y2t4pz/2MUe4vU=; b=vQFr0cXOK2k6s2LBbMxy18n+vHuO3vgqzwAa8uZi5GQ/33UfElSPl5vnovhAqIOJ60 LcGmvzZyqaEmtzyogjNpOYwq0fp6rkhPb2r4FCN7cjL0mlwHb3djhOHLnwFW2Dxg1tfe dO8BNNYY2B8V+We+kxZvblMID7FGHnr8S633tfcobxFtEaiASREcOdKM+NE4T5K6p1Cr MVWW60RSxPNbIUILqU7biidCaOG3slu4V4qcbok/ZH3wA6xRTlGp7efDGfK/m9e31oQ2 3A/tylal/HzboLldDs644bbyCypc0ox1ybkGFTKebSwCh59PMrmgFak9tM/DKA9jgWBQ ki4A== X-Gm-Message-State: AOJu0YzBwMzsElalJFXXOy+EKzBPurqqoofJNnd25DpUZYh7Hu00852O c3RGJw54GaPZkymRWe9Z5Fq7oDW9LkKtA6bN5DTULLSZmhPZz9bCaCav47XMwCotgWBbqmafiHs 7jhS38WIJ5G5lsGDGtniukTRc3nF55OstWpfKz9MeRC5z6lzutxpGYY+BrTjQ6R8= X-Gm-Gg: ASbGnctZplWE7JONtybZ9I98vaXSYMaJyc5U2ol8tP1C6RcliKsF2Xute6ir3cVB8y6 uiQ3Ki1K5yTYC+MWwhRoOGC+sXiS+RtiRZ/Xkc0asOvKhZdKNTBy7PwYqhyw2Tfti6KyLXeaGc0 TY+iQVfYqr36wSnDI5WZQoWm5ZWrKb7VPj6VDkerRYJPDD6zZ/gUdC5/hcBHfQGicOQoVUQvGNJ lKRXa/fI2JyFrddOmQn/uxtwym8yHglBmQho0pz1O+xXjMSVgbFwe0Tn0qMngvMpTQoU/Vzimfu UB5fMjcuAvkiyoXm8Hi9fxDFAjn61+h4aEVoKGtxSMdeq5jdgImWi7Bj1LB30aQUWQc+wg== X-Received: by 2002:a05:600c:6d17:b0:477:7588:c8cc with SMTP id 5b1f17b1804b1-4778bccfe23mr19350145e9.7.1763051526370; Thu, 13 Nov 2025 08:32:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEp1REAH+NcLVbwOmkhQ3NA6gewQhPfL9iFI7sGfVsw7fNSv+HCvzeLkh5RTmnbIwJ5V2D/dA== X-Received: by 2002:a05:600c:6d17:b0:477:7588:c8cc with SMTP id 5b1f17b1804b1-4778bccfe23mr19349975e9.7.1763051525932; Thu, 13 Nov 2025 08:32:05 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778c88bee1sm55793865e9.11.2025.11.13.08.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 08:32:05 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3] gdb: remove attempted type de-duplication when building gdb-index In-Reply-To: <87cy6fkltn.fsf@tromey.com> References: <5fb2ed381ab0f96c5057f1644ca67dceebcdf3b7.1760638029.git.aburgess@redhat.com> <87cy6fkltn.fsf@tromey.com> Date: Thu, 13 Nov 2025 16:32:04 +0000 Message-ID: <87o6p5zyez.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DmQuLR1hpdXA0_RI6-e7BI14DSW3tqIC4YGf0AuuBRs_1763051526 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> In v3: > Andrew> - Fixed test failure in gdb.cp/stub-array-size.exp when using > Andrew> cc-with-gdb-index, using more recent versions of gcc. This did > Andrew> require additional changes in dwarf2/read-gdb-index.c, and removal > Andrew> of a test that is now out of date. The commit message has been > Andrew> updated with a full description. > > Thanks. I think this is ok. See below for commentary but there's > nothing you need to change. > > Approved-By: Tom Tromey With this patch now merged: https://inbox.sourceware.org/gdb-patches/c7599a8d2d8408eafd08919e77dd6e31309b55e1.1762874404.git.aburgess@redhat.com I've rebased this work, updated the test a little to take account of the improved 'info types' output, and pushed this patch. Thanks, Andrew