From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YW9YFGcahmkZWywAWB0awg (envelope-from ) for ; Fri, 06 Feb 2026 11:44:23 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Kim6P8nv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4681D1E0BA; Fri, 06 Feb 2026 11:44:23 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A08F91E08D for ; Fri, 06 Feb 2026 11:44:22 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3733C43B5D86 for ; Fri, 6 Feb 2026 16:44:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3733C43B5D86 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Kim6P8nv Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 63A0643C1CAA for ; Fri, 6 Feb 2026 16:43:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63A0643C1CAA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 63A0643C1CAA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770396191; cv=none; b=JGUOCIdlDUqfYMB4nt4/ONUZQm48jOJGuyw1PM9lF5HpxzoNfdsIatV7weipQ1cqjSjfwc13OVQ0j8OCd2jxOqgWk9meC7ez8joZ+7jNKpjxMrM2otgIZqi04DJuVxS4MKhZiBP48wpoIJl3ppwuK/nx73ZwfKRaVnB4UzZR+cY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770396191; c=relaxed/simple; bh=QuHV5f0IDouTHU6SIGDWnh1GnpWX/Reg2RpOQf1DE94=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SpWQevdZ11U/skdPGwrH8YskJBUxRIw2U54E/1vbmvUpU1SvlQdFEb9TxNDz5MTFE1tLc1/OX0Be3ad6OHyide2zJ+MbZ0qGsPH5UtDGDJATLBHX5Ovvt+vYrQ7v9EVKW3VgoRyN50WfRYDaJnjbL4DFkgkYSqF4ZPDMAcgQsKM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63A0643C1CAA Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id oMbcv6n2vKjfooOvGvsron; Fri, 06 Feb 2026 16:43:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id oOvFvqX9IHSQMoOvFvXVW8; Fri, 06 Feb 2026 16:43:10 +0000 X-Authority-Analysis: v=2.4 cv=GIQIEvNK c=1 sm=1 tr=0 ts=69861a1e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=3EEuDYQEwBE4NiDwHN8A:9 a=zZCYzV9kfG8A:10 a=uqOk3ZSnBfCTOznnrPA1:22 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QuHV5f0IDouTHU6SIGDWnh1GnpWX/Reg2RpOQf1DE94=; b=Kim6P8nvGT+wiyKx/QqUuupPhK HbuB64RnxqQahUktoNDxFosWZOxm1xVLvHXaXPtkwr2hmhXBbGlFUHXVxWg7qfIWLBOyB5dNDafWf LiIl/5k3rSByHLs9ioGR6RIL5; Received: from 97-118-49-200.hlrn.qwest.net ([97.118.49.200]:44806 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1voOvF-00000000tpL-1tiR; Fri, 06 Feb 2026 09:43:09 -0700 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 2/2] gdb/block: add assert in block_iterator::compunit_symtab In-Reply-To: <20260206025238.3467043-2-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 5 Feb 2026 21:52:31 -0500") References: <20260206025238.3467043-1-simon.marchi@polymtl.ca> <20260206025238.3467043-2-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 06 Feb 2026 09:43:08 -0700 Message-ID: <87o6m14ycj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.49.200 X-Source-L: No X-Exim-ID: 1voOvF-00000000tpL-1tiR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-49-200.hlrn.qwest.net (bapiya) [97.118.49.200]:44806 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOjb5oqCRP/bb9B9ht2WLPFNGk/5a4/JkTpYVgwcTdhtb7I/KusoS4AC59ILYxHdSyz/sZm7HesryeBssXpdktnA+b854XK2WfFLC9KaK6lmHtrxlZ8B 9uLAbL4c9JDywO76C0TeoBEl3v2pCUvIrfwwRq9MjQBNnYiL0QioeNwfTVF0A6i8MEMN+Eh7AsDq22WVwTqGXjQpRi9GXNKlgSE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> Verify that the compunit is only accessed when the iterator is in the Simon> mode where that field makes sense. Simon> We could also set compunit_symtab_ even in "single block" mode, it Simon> wouldn't hurt, but it would not be useful either. Thank you for doing this. Approved-By: Tom Tromey Tom