From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CTPENweeoWlkjQwAWB0awg (envelope-from ) for ; Fri, 27 Feb 2026 08:37:11 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=adDLBzBG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DE8EB1E089; Fri, 27 Feb 2026 08:37:11 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 69BC91E089 for ; Fri, 27 Feb 2026 08:37:11 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E9BA74BA23FF for ; Fri, 27 Feb 2026 13:37:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E9BA74BA23FF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=adDLBzBG Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 92D064BA2E1C for ; Fri, 27 Feb 2026 13:36:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92D064BA2E1C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 92D064BA2E1C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772199390; cv=none; b=Xl50l+OBfZIqgGHdQnN3WU4kzhf1BKiWDCumVyU6wGzEbJzWpZshduJtRrQgTnDHaKCb0lYf3NWtobIwYlE5pCTuKevZRgySle84GAhHt2YANUxBRZuvjIbGlAE3h3TU8DK4E6VyFob3MOcTbmZwjiz3kTx5eq9ioA0lnYpPIfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772199390; c=relaxed/simple; bh=g82puK2gfJQDfZmLsZrgb912scz0A0B8skZDgPiBS+o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ByyliDfXZqXy2eYCVmou41jmeS64HtRYyUkyM8n3fbvQF/ql5m0xfuOs3aYBrajW3O+HDBkzL3UzkMFV88tXVH0OZ+pU/Ksfj0ebpxQfvo0TqgQwYwJvEVLdysbBJa7aO99qaiZx+T20vvv69i7I+IcayX0HhbnwjYhq1/gRy/g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 92D064BA2E1C Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2a9296b3926so16299035ad.1 for ; Fri, 27 Feb 2026 05:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1772199389; x=1772804189; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=fZEs5rbL8x+AOqSyMaDr4VJQ7286wdwN7bAkJPBtrow=; b=adDLBzBG29kJ06LidhzqK3dr7otuFYP/msZIKQFJ3cvlwzVv1TAhXy6vLCM+iE+/uQ iJ5BpleOrj1EsgrHvTnLEGC4xUuNmYHhvC3vB1wAokizgWIudM1k4b5T7o61wCr2LiHT ibmJyN5QeTMTCDo61QGbNU7S2uZ9cvIainhGCciADPjPfCLAf24k7MT/OIJuXqjtvyXD biolRoLPefLIxx/KZ47MROb0rlNHwfiwaL5RWdsOrc89JHz6fyIget0r/D6H5sfy6vKF CakXKDUzDoCaboZqZS1w1104OxBqOWBT6QQSD65C3avY0eQL1+OnW1FS0JYmYhAkdI2i BDaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772199389; x=1772804189; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fZEs5rbL8x+AOqSyMaDr4VJQ7286wdwN7bAkJPBtrow=; b=Jr039Z9QZ4VKLjnMwGXQ0ReDpR8PMA6rF/l/eyoRDkzIAeAtLIG0XzZaPKAI0IliQH 4kxuye+5DUxKB1Lu1puoHU1JWWgWuZRW47f/zG86AwhNsWAWcrzmmLI3z8L5+gRpTyNn 4plhgcg+eMG9CLVWjoWsiMYbVqBequKwSrzgM7e6XZ5a62FmV4qm6rIAto4MF0kFxjqn qun5DvOO4+n5jfLr2PLAYLmXshx76M5N2TD/SOkoXLglIORgVzeg0iAZHbiZi8nRO0LI jXCNJfWvN/2c5MzzoaJa5QXN5BXbf6fmOupII0DR/l7h0wEubePD/Uk8KSayUzVuYEzt lJ+g== X-Forwarded-Encrypted: i=1; AJvYcCVO77n+csH9cH2fHaIBkz7coBkYAHiPBnFiIGSmmY10l+dHRx+bfWoxUT/frqshZTmGznCjGw8WxWvKlA==@sourceware.org X-Gm-Message-State: AOJu0YzzjBSrxM3ketKlitr1XXskgK5PToygfOQYhPJ+WKimia0Uv3z8 JvhO81G+LVQDMSp+JhAIT0es87jmaZ6+8eJGWgxeHVR0WhlhF8LgYb8Zwz4Z/B8/d6EBHDRjtqg 2qX8= X-Gm-Gg: ATEYQzxLwYlyqIPrgEvS5MLbJGaB88kdwLN/FwuclwkAXA5QWhOImKRoidbtsPK5j4O Lr4ng116WBZsB06QR2dntNWOgXkGQ6VuUNGirt6r4aaBMT3HVg8c/kL8GJ2hii6CoVKiwkyewnV NDREOIQ6Ejt44TAyeR4IySUmySlW0ihJ96nBgAJUixKHeAzKGDgXNhTmZpYLJjKHbOER5iFAe6+ bdNUBFvD93y7jm2oOqy7/yjM1Cw98cspuzuKPlKNv4EanBNN2nClti1Cj6St+TripgdUH2/N1KZ r6VleDVApSIlVacZxN2CQX2peO7s3SjoE8FRRO1rGOVDzD2dYWEfYqyjqM0HYAsYSxESBHQDp7p mErGEmWVYSQ1LlZP6FNPQAFKZFAL2c3dkGgo6HbFj2DKd/MN+vO0DNXU0FcguTISTFzEwgH7cVJ eLPRZRkvkf9Oc9nY1Tn8C/Ifew1BxV3BoxdVTqC1w9czQ62Q== X-Received: by 2002:a17:903:1a03:b0:2ad:a9a8:5039 with SMTP id d9443c01a7336-2ae2e3d64e8mr25661585ad.35.1772199389480; Fri, 27 Feb 2026 05:36:29 -0800 (PST) Received: from bapiya (97-122-122-234.hlrn.qwest.net. [97.122.122.234]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6cc91dsm61799745ad.74.2026.02.27.05.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 05:36:29 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Use a newtype for remote file descriptor In-Reply-To: <32b6cfc1-d500-462c-a14d-4999e66afe76@simark.ca> (Simon Marchi's message of "Thu, 26 Feb 2026 11:43:54 -0500") References: <20260225-target-fd-newtype-v1-0-e04af6692ccb@adacore.com> <20260225-target-fd-newtype-v1-1-e04af6692ccb@adacore.com> <32b6cfc1-d500-462c-a14d-4999e66afe76@simark.ca> X-Attribution: Tom Date: Fri, 27 Feb 2026 06:36:25 -0700 Message-ID: <87o6laux46.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> target_debug_printf_nofunc ("target_fileio_open (%d,%s,0x%x,0%o,%d) = %d (%d)", >> - inf == NULL ? 0 : inf->num, filename, flags, mode, >> - warn_if_slow, fd, fd != -1 ? 0 : *target_errno); >> - return fd; >> + inf == NULL ? 0 : inf->num, filename, >> + flags, mode, warn_if_slow, int (fd), >> + int (fd) != -1 ? 0 : *target_errno); >> + return result; Simon> One more nit: in this function, you don't need to case fd to int, since Simon> fd is an int. You could either remove the cast, or use `result` in the Simon> debug print. Yeah, I meant to use result there, I've fixed this. Tom