From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SlAwK4lKwWkzuzUAWB0awg (envelope-from ) for ; Mon, 23 Mar 2026 10:13:29 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jahGk4S2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 960881E04F; Mon, 23 Mar 2026 10:13:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A17941E04F for ; Mon, 23 Mar 2026 10:13:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E75D84BAE7EE for ; Mon, 23 Mar 2026 14:13:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E75D84BAE7EE Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jahGk4S2 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 042D74BA23EE for ; Mon, 23 Mar 2026 14:13:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 042D74BA23EE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 042D74BA23EE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774275181; cv=none; b=meKgyEMq1n0crCDUh7Nkm/dP4G9Jck+W/u3bKgZChC43BCB5go6tp4QN1e0uxNUAsm8WmqJzmyS5jN0y4gx0JAIo1F3GhrLN5m5PEBX/F25ODtiRIIyS9PxrFXywuC+PIJP//1vhpZ+zLbgfaF+YDrrTQOr+kBI2RIZ7ObEJDTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774275181; c=relaxed/simple; bh=n9xhq+fPHUO53h46s4CbQeZnyFCIpLOPxhzXNcqp+EA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Yfl8NoRmbdSzriMZkv26Jgl7i95t+iucxJ3qdFweW9S4PVTJI9QvUxUWPE+BO13BIMKrBDOQB5G2xnyv0kuQMPexgVnKtVSJVzmCGPI7d6atX6lUE8/ewxce076IYhelyu3CjGXehxzvfv/nVUUaWx3CW2oOUXE5mYApn2rIov0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 042D74BA23EE Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id 4dycwuAiOJ9SZ4g1cwJqaR; Mon, 23 Mar 2026 14:13:00 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4g1bwZLlIPL324g1bwkGjd; Mon, 23 Mar 2026 14:12:59 +0000 X-Authority-Analysis: v=2.4 cv=MqhS63ae c=1 sm=1 tr=0 ts=69c14a6b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=Frf5se2TjagLk9sj0AoA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QHnp8DEOrKUHMmhpfx3CkP0rliJhNSTHqhX+2843kkc=; b=jahGk4S2NcMpxSGzs1dCIs1ATr OlYf02+PaIxyal870XLfmlIgJj2R8M5gNimjodCiUmQOA5TvabnQ90RBHrvIfwe51DTrymJu/oCen CATex3xzQKNwPT8DKOqniuevL; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:60020 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w4g1b-000000002dX-0EQp; Mon, 23 Mar 2026 08:12:59 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] [gdb/remote] Reimplement escape_buffer In-Reply-To: <20260321094433.3298268-1-tdevries@suse.de> (Tom de Vries's message of "Sat, 21 Mar 2026 10:44:33 +0100") References: <20260321094433.3298268-1-tdevries@suse.de> X-Attribution: Tom Date: Mon, 23 Mar 2026 08:12:57 -0600 Message-ID: <87o6ke8wie.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w4g1b-000000002dX-0EQp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:60020 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEYg0k9vUKsELzfKsgfF2S/asmBVqWrKEeqp9h4nnI6IHpCZ0JDUX2drEU0uAffxwNjzd7H1d8F+G7h/s9dlWMFhCWwrv4VLI0ghM9tEBfiAewPu+AFf hEemXefz4pCjbRrLXnnfzu/popZKrjzwDMLbfYgWhb0HNqRWtwsqoszKIAJwy5mJUHeEXcnjMvKverH5QAh5jT5UEcNZaX7Yjy4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> Reimplement function escape_buffer in gdb/remote.c, to print c_isprint chars Tom> like the actual chars, and others like octal escape sequences, getting us Tom> instead: Tom> - stb.putstrn (buf, n, '\\'); Supposedly putstrn does this quoting already. Why doesn't that work? See ui_file::printchar. Tom> + /* Append 3-wide leading zero octal \ooo. */ Tom> + string_appendf (str, "\\%03hho", c); I wonder if %hh actually works properly with the gdb format code. I don't recall ever seeing this before. Tom