From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 93dDDJvbwmkY2TcAWB0awg (envelope-from ) for ; Tue, 24 Mar 2026 14:44:43 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jKmrZteF; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E53611E0BC; Tue, 24 Mar 2026 14:44:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 48B471E08C for ; Tue, 24 Mar 2026 14:44:41 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C5A604BB3BFC for ; Tue, 24 Mar 2026 18:44:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C5A604BB3BFC Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jKmrZteF Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 361CB4BB3BB1 for ; Tue, 24 Mar 2026 18:44:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 361CB4BB3BB1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 361CB4BB3BB1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774377853; cv=none; b=LwmoktRGb7CB8cvWDfTrPfxTtIoHqvExwtE3c+w6ijMUJgfw7W3ETQWBvPlsA/GM+xg68NbwEOFvWZYw9Mz0A/IaHDM70EXdVqtEghMGw50TyI/g/ESRNQCoGGT1DiBmfhDQcCcbRH30vyreAOq8uV1FC7r5wPT/bKWpH9OIAG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774377853; c=relaxed/simple; bh=3mubtSN3y3yzeH4uAezM1DSGeUslYg+W4ocprjoPOUs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VyT0VxeSE/P8sWqCDeX4pZDQhaKdWJdJ12C6QrSFVar5WaJpOveMBIJ+ITyy6B32T1JGNJ5trOkBbtJG88NlaueYq2x2U0Ukw9+k4zYUpWAr2FfumD3FCLLIXXmZbFpYtABa8RLGgHgH+jB0sv9xBDnlughduRDcdeJHGLHXvYU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 361CB4BB3BB1 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id 54FBwzw9ZJ9SZ56jcwXVIF; Tue, 24 Mar 2026 18:44:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 56jawp8DAcu1156jawVCFU; Tue, 24 Mar 2026 18:44:10 +0000 X-Authority-Analysis: v=2.4 cv=bKYWIO+Z c=1 sm=1 tr=0 ts=69c2db7b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=zstS-IiYAAAA:8 a=pXZzhlvciPUbJJjjQG0A:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3mubtSN3y3yzeH4uAezM1DSGeUslYg+W4ocprjoPOUs=; b=jKmrZteFjay88YBs6/KUwHldhZ TwX01gtpSk4yIGFoaC8FSs+PWmivzyLV6T1fBm0BxYJ04+66ASwjni0p+Boh8WRCEsQf3pkZomkTQ hN0kW8MdbjJJOtSZHVu3tru+F; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:54286 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w56ja-000000032WV-1cUc; Tue, 24 Mar 2026 12:44:10 -0600 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v3 3/7] gdb: add new helpers for retrieving a type's fully qualified name In-Reply-To: <20260309175624.236491-4-matthieu.longo@arm.com> (Matthieu Longo's message of "Mon, 9 Mar 2026 17:56:20 +0000") References: <20260309175624.236491-1-matthieu.longo@arm.com> <20260309175624.236491-4-matthieu.longo@arm.com> X-Attribution: Tom Date: Tue, 24 Mar 2026 12:44:09 -0600 Message-ID: <87o6kd5apy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w56ja-000000032WV-1cUc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:54286 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMcpv8ahYWtp1TtNEnCGJVAVPhIRuO3qlG6voOCY4fy67rPvEyt2D9UwNtv7wap+/j34TGPVBzbf2GM9dRJ/9NKvCDmzD9Bb2AQOMfrgk7ghj7zQJUQn Jt0CBp1luz++1ePlHZ/5AW3+HWcw7F2GtgfTdVXgLfH0ogW+yTecWOGfdEyh2H8vf5/DRStbf0q9mRuNxspQ1z/MML0gVocEjzg= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Matthieu Longo writes: > Py_TYPE (self)->tp_name is the traditional idiomatic way to get a Python > type's fully qualified name. However, in the context of the Python > limited API, PyTypeObject is opaque, so the 'tp_name' attribute is no > longer accessible. Additionally, retrieving the type of a Python object > requires Py_TYPE, which is only available as part of the stable API > starting with Python 3.14. > This patch increases minimal Python limited API version from 3.11 to 3.14. > It also introduces two new helpers to retrieve a type's fully qualified > name: gdb_py_tp_name() and gdbpy_py_obj_tp_name(), which extract the fully > qualified name from a PyTypeObject and a PyObject, respectively. Ifdefery > allows these wrappers to select the appropriate API depending on the Python > version and whether the Python limited API is enabled. For any Python > version less than 3.13, gdb_py_tp_name() fallbacks using __qualname__ > instead. However, the result may differ slightly in some cases, e.g. the > module name may be missing. > Finally, this patch adapts the existing code to use these wrappers, and > adjusts some test expectations to use the fully qualified name (or > __qualname__ for versions <= 3.13) where it was not previously used. > Note that the corner case where the module name would be missing does not > appear in the testsuite. Thanks, this looks good to me. Approved-By: Tom Tromey Tom