From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QnvvJkoTD2pMwgwAWB0awg (envelope-from ) for ; Thu, 21 May 2026 10:14:34 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ffDCwqup; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8447B1E098; Thu, 21 May 2026 10:14:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE6A41E024 for ; Thu, 21 May 2026 10:14:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4129448F90C2 for ; Thu, 21 May 2026 14:14:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4129448F90C2 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ffDCwqup Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 097C24BAD14F for ; Thu, 21 May 2026 14:14:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 097C24BAD14F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 097C24BAD14F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779372849; cv=none; b=SHpeH+f9EB8+/ZNWXlPwpYKkr9RMWYaIWA7HJjHT0Zp5legZoNg3T3Ifz7778XkPCR0x1CAU3FeewySAIQ4yMMMfNfLyLFuR20PkIGsbCZvHE63fauvPjLPRUf1a7jt1yDUsKnWIPNzthkf2xsNesiJ8QMWdO5QX/TnPEAO9Lsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779372849; c=relaxed/simple; bh=HElXhDmeNfOhgyO7DomP/SK7y7NmJaUElCZ8jmwlkIM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=veqkJnYalrTkTzZBAwWtYci0xQmg9c4JS8PE8xwXbiG/Z997CpIHjqdiLOGUObBGW79p1zPrrtrOFX6UNF2+5bYZZlwsKb2Jc3Tbi9LiouKqGz61WdL3kzkNEwEv05svNLR+oxZqxIFwJvJUYB23xQBbzNwmmUidW7gK9OpueJw= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ffDCwqup reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 097C24BAD14F Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id Q0cVwb8t3MFEgQ4A4wttNa; Thu, 21 May 2026 14:14:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Q4A2wiAsPfpvWQ4A2wUj6h; Thu, 21 May 2026 14:14:07 +0000 X-Authority-Analysis: v=2.4 cv=Y6j4sgeN c=1 sm=1 tr=0 ts=6a0f132f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=PQfS2hOV0Hmd_13s55kA:9 a=FeVyTpuETfYA:10 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HElXhDmeNfOhgyO7DomP/SK7y7NmJaUElCZ8jmwlkIM=; b=ffDCwquppa3HTM7bo6PnJtkTND I0FI7DNIeqKrZHeOmktOrlniTic7bzKh4sS/Fch2iJa8RXIKsdc/GMf5J2jpiPosv53AoSe6T8yDR 91ZF0OIsNu3mcEtD6SqEMpFe+; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:33034 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wQ4A2-000000029F0-1wXW; Thu, 21 May 2026 08:14:06 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf: make dwarf2_per_bfd::get_unit return a reference In-Reply-To: <20260520181610.4066987-1-simon.marchi@polymtl.ca> (simon marchi's message of "Wed, 20 May 2026 14:15:39 -0400") References: <20260520181610.4066987-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 21 May 2026 08:14:05 -0600 Message-ID: <87o6i8alzm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wQ4A2-000000029F0-1wXW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:33034 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLyK+6jgNOFKC4+SXPxzbftYMRHXc12jYCym1/B1eQmhbI/iPtXKQEWQ1I5XPDujr5iYNE9emGL9Sl0yGEjuvczilTmzh6Zv1OF1iWqfVpOqBdpEAQZh 3bd0akbzGqSIk6VixntAmBisbW5Mk9A1CsbjWYNbaUSx252SZYCVK93AuKTsGKETZ2DOafgI920NzhMDKIffmbkqxV2P25quIXY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> This method can't return nullptr, switch it to return a reference. Simon> Change all_units_iterator::operator* too. Ok. Approved-By: Tom Tromey Tom