From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0eXaFJcAVWqFWAYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 11:13:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZqsYxy6s; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5188A1E033; Mon, 13 Jul 2026 11:13:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E7C4B1E033 for ; Mon, 13 Jul 2026 11:13:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 88A354BA2E1C for ; Mon, 13 Jul 2026 15:13:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 88A354BA2E1C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZqsYxy6s Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id CB08A4BA2E0D for ; Mon, 13 Jul 2026 15:13:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB08A4BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB08A4BA2E0D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783955581; cv=none; b=pgLa4FSyx+9ak0OKEeD4jRNxx4XzFK446Bf/iyy0VqpXlNBYJ52ly7y0y2TN/StIACi0jW7rLrJXohAlUBJsDcVZfcuESrJtyEVzURFwIp8HpJNA2wgDzCaSTQyjV5/Wbd1BiIZfaVOftfSKU5swA/hfHs3tMeUOTwAWvFi51Qo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783955581; c=relaxed/simple; bh=N9WqKoTUlih4FeMuEf2M/GCFR5XTlwX0ALiKc4cimf8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VEQNujeqZUZEWAMfQbpvA8T1NagEKQG/d65hFZn90Fx2wZYobY27wpwwOlrAFUGmnO9YvfwPUn3l7Pi8WBRPCTGSmNOcskWzlluTwVx2m9Fb4WBQTK/I0iBeXs4GkfvOmWq0hIIDWXQXuVWs6EfvVyMfonzbaCNvO2rr9BVx1MQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZqsYxy6s DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB08A4BA2E0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783955581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oUe23RoPDgo0Idue2OnkLANZZfVWNmrYxFG6S0CjfUo=; b=ZqsYxy6sq9vFL/OB86U5NZNFuqBgHZsf7h5mFTJ8IrqQs6lQl6bQ2B5kYnipdTXiBqZANE ai0D4F6Uv8/+TyJFbM2CiHBmeR3Q6vuTVO94zHGnF9DghUiWytUNEST136MUeiflxu2iL+ ujJKNj5umITRxCTCM0zccsxpI+WUtbA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-eTzymPNuOFW3HTIb4XKaLQ-1; Mon, 13 Jul 2026 11:13:00 -0400 X-MC-Unique: eTzymPNuOFW3HTIb4XKaLQ-1 X-Mimecast-MFC-AGG-ID: eTzymPNuOFW3HTIb4XKaLQ_1783955579 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4767036f8faso1952901f8f.3 for ; Mon, 13 Jul 2026 08:12:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783955579; x=1784560379; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=oUe23RoPDgo0Idue2OnkLANZZfVWNmrYxFG6S0CjfUo=; b=tEmR/PIobry+K4TdD7UhEud4BCxAl+wyNERKzHSZ0KWpZQN1grZklQQrmab1dObevw Byh4uZCxTw6TJAYxzBnqVffNio1Q5x6S52sbHgMup/xLvbMTvemNE+mOIHw1ZB/6zPKk 347xcMC0erZjpXR/nvIrqv/IV2th/c6sDnJzG3WOnHJy8ZilVJ8iumk0zLUvzXcP/TrO CTBEa3ResQFmnhhZcyKa5CO36O36ruAMKhS/5R2gENIvqAJ7iK75VphSCv0sqRW9V6S6 VCmut/3kPlWRMldQdXIjEFqQF6j/t186sbNttX5UoCoMm969J+V4aMwg+ne/nbCqbaQi Dbqg== X-Forwarded-Encrypted: i=1; AHgh+RqOHi9gHrePzpL0DX5Lm39GaIsWM4iT5PN9goedCX2Q8qvpp3tjp+gfDKcaa07Agwly0pUa8NTzSNlR4w==@sourceware.org X-Gm-Message-State: AOJu0Yz3wX0EocuL+PNCUVJSmI6TtRufWcYXrNGcwgWFSWZa4ws4tcSM hY4eT4EU94pmyGd/6PB/sCYtIa+G/4ixjEkX0jFyt1yL8nEl4KlOLpLzMj6ZBX1D0xiffc2ayV7 PRIShy5O6XxMgyeYH5BjCr760arQRjBwVNcs+CM5YFMVY9V+MJ+Umj/nE/nGZ+bQ= X-Gm-Gg: AfdE7ck0e4zoasMiI6xEN/r8qg3ju7VqJWqxQ0efGXMN36/172UtIV2crSVFUJz7pRO Y9ScuZqi9oiC9yj9t3HytsJIbxnaxnaJzeAiBF5yZw8vuP8304QJRdB1rJAz6O9rh0x9XdPIf+h mYVc5nwOYJJFQFjScXjJnAPkGWTUovj7zxfB5XamOxPVoUlif3iH6Kk22ZHO3VoFzA877TXI9zL oQMNr2iXCmOP6Benppt0bV2O2USxzfGdT2owiQPmJPMWrNc5Gjc/lByMBnZidcOIflLBpDngbuZ DZJrTZ7b5dMwMMzAQOxJ45LUBkRWG8xE+cVWwIo76pyZw9pubz2z39p4UFUAM74Obj2FgWvNIt/ YggymOv8= X-Received: by 2002:a5d:588d:0:b0:47e:b898:c580 with SMTP id ffacd0b85a97d-47f2dcb4510mr10888116f8f.13.1783955578813; Mon, 13 Jul 2026 08:12:58 -0700 (PDT) X-Received: by 2002:a5d:588d:0:b0:47e:b898:c580 with SMTP id ffacd0b85a97d-47f2dcb4510mr10888087f8f.13.1783955578438; Mon, 13 Jul 2026 08:12:58 -0700 (PDT) Received: from localhost ([31.111.209.233]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f213e8sm85406686f8f.34.2026.07.13.08.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 08:12:58 -0700 (PDT) From: Andrew Burgess To: Abdul Basit Ijaz , gdb-patches@sourceware.org Cc: pedro@palves.net, philippe.waroquiers@skynet.be, christina.schimpe@intel.com, lsix@lancelotsix.com, eliz@gnu.org, abdul.b.ijaz@intel.com, guinevere@redhat.com Subject: Re: [PATCH v13 1/2] gdb: add annotation in 'info locals' command for variables shadowing case In-Reply-To: <20260708180805.207722-2-abdul.b.ijaz@intel.com> References: <20260708180805.207722-1-abdul.b.ijaz@intel.com> <20260708180805.207722-2-abdul.b.ijaz@intel.com> Date: Mon, 13 Jul 2026 16:12:57 +0100 Message-ID: <87o6gaexdy.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cJ0aFHIP8-f_7kFoICJTTXYNeN081nO7KYP2fPotNTo_1783955579 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Abdul Basit Ijaz writes: > --- a/gdb/printcmd.c > +++ b/gdb/printcmd.c > @@ -2377,12 +2377,17 @@ clear_dangling_display_expressions (struct objfile *objfile) > void > print_variable_value (symbol *var, const frame_info_ptr &frame, > ui_file *stream, int indent, > - const language_defn *language) > + const language_defn *language, > + var_shadowing shadow_status) > { > try > { > struct value *val; > struct value_print_options opts; > + const char *file_name = nullptr; > + > + if (var->symtab () && var->symtab ()->filename ()) > + file_name = lbasename (var->symtab ()->filename ()); I suspect there might be some history here, but did you consider using `symtab_to_filename_for_display`? If not, then it might be worth a comment explaining what that isn't being used. Thanks, Andrew