From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Aditya Vidyadhar Kamath <akamath996@gmail.com>,
ulrich.weigand@de.ibm.com, tom@tromey.com,
gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com,
sangamesh.swamy@in.ibm.com
Subject: Re: [PATCH] Accept ksh88 exit status for SIGINT in shell.exp
Date: Wed, 21 Oct 2026 10:33:16 -0600 [thread overview]
Message-ID: <87o6cnypwz.fsf@tromey.com> (raw)
In-Reply-To: <dbb6eeb9-b468-4e66-a383-cceb391e1a3e@polymtl.ca> (Simon Marchi's message of "Tue, 20 Oct 2026 15:45:36 -0400")
Simon> What is the value of the SHELL env var with ksh88? Instead of doing an
Simon> "aix" check, would you be able to tell from that variable that the shell
Simon> is ksh88, and update expectations accordingly?
I was wondering whether the test should simply unconditionally allow
either value, since they both seem valid in some sense and since this
would avoid having to maintain a list of which shell does what.
Tom
next prev parent reply other threads:[~2026-10-21 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 13:46 Aditya Vidyadhar Kamath
2026-10-20 19:45 ` Simon Marchi
2026-10-21 9:08 ` Aditya Kamath
2026-10-21 16:33 ` Tom Tromey [this message]
2026-10-21 16:42 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6cnypwz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=akamath996@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
--cc=simon.marchi@polymtl.ca \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox