From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25475 invoked by alias); 11 May 2006 12:37:00 -0000 Received: (qmail 25465 invoked by uid 22791); 11 May 2006 12:36:59 -0000 X-Spam-Check-By: sourceware.org Received: from jess.glam.ac.uk (HELO jess.glam.ac.uk) (193.63.147.97) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 11 May 2006 12:36:56 +0000 Received: from mailserv1.isd.glam.ac.uk ([192.168.244.1]) by jess.glam.ac.uk with esmtp (Exim 3.35 #1) id 1FeAD9-0004HF-00; Thu, 11 May 2006 13:24:07 +0100 Received: from floppsie ([193.63.148.84]) by MAILSERV1.isd.glam.ac.uk with Microsoft SMTPSVC(6.0.3790.1830); Thu, 11 May 2006 13:33:59 +0100 Received: from gaius by floppsie with local (Exim 4.61) (envelope-from ) id 1FeA8h-0008Hi-Sb; Thu, 11 May 2006 13:19:31 +0100 To: Jim Blandy Cc: "Eli Zaretskii" , gdb-patches@sources.redhat.com Subject: Re: Enhanced language support for Modula-2 References: <87psjc9yu3.fsf@glam.ac.uk> <87psius247.fsf@glam.ac.uk> <20060504153726.GA2396@nevyn.them.org> <8f2776cb0605041101u7d969e0eodde33866ac4abc41@mail.gmail.com> <874q00liyr.fsf@glam.ac.uk> <874pzyrf8l.fsf@glam.ac.uk> From: Gaius Mulley Date: Thu, 11 May 2006 12:37:00 -0000 In-Reply-To: Message-ID: <87mzdosqi4.fsf@glam.ac.uk> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00213.txt.bz2 Jim Blandy writes: > > also enclosed is a proposed set of ChangeLog entries: > > Looks great! thanks.. > Two points to fix when you commit; don't bother re-posting the patch > for review: > > - There's still an overly long line in m2-valprint.c, in the > TYPE_CODE_STRUCT case. ok I'll fix it.. > - Similarly, there's a separate ChangeLog for the doc directory; the > entry for your change to gdb.texinfo should go in gdb/doc/ChangeLog, > not gdb/ChangeLog. And generally, we put section names in parens > after the filename, as we do for functions in C files. Like so: > > * gdb.texinfo (M2 Types): New section. ok. > I see that you have a copyright assignment on file. Do you have > commit access to GDB? If not, we'll have to get you set up with that > first. no I don't have commit access. Commit access would be great, thanks. > If you do, then make a commit to gdb/MAINTAINERS, adding yourself to > "Write After Approval", with an appropriate ChangeLog entry. Then go > ahead and commit the rest of the patch. sure, will do. regards, Gaius