From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19289 invoked by alias); 20 Feb 2012 16:16:39 -0000 Received: (qmail 19279 invoked by uid 22791); 20 Feb 2012 16:16:36 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Feb 2012 16:16:04 +0000 Received: from nat-dem.mentorg.com ([195.212.93.2] helo=eu2-mail.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RzVuF-0002Dw-3L from Thomas_Schwinge@mentor.com ; Mon, 20 Feb 2012 08:16:03 -0800 Received: from feldtkeller.schwinge.homeip.net ([172.30.64.210]) by eu2-mail.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 20 Feb 2012 17:16:01 +0100 From: Thomas Schwinge To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [SH] Prologue skipping if there is none In-Reply-To: <20120216182544.36b41a1b@mesquite.lan> References: <87pqdgciho.fsf@schwinge.name> <20120215075413.1313f7fa@mesquite.lan> <20120215165907.33f2e9a6@mesquite.lan> <8739aad9il.fsf@schwinge.name> <20120216182544.36b41a1b@mesquite.lan> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 20 Feb 2012 16:19:00 -0000 Message-ID: <87mx8da3b9.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00407.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2037 Hi! On Thu, 16 Feb 2012 18:25:44 -0700, Kevin Buettner wrot= e: > On Thu, 16 Feb 2012 17:32:18 +0100 > Thomas Schwinge wrote: >=20 > > I now have (on a SH7785-based board). My patch fixes a few more failur= es > > than yours. ;-P >=20 > This will require more study and discussion then. Heh, indeed. :-) > I tested against > the simulator using the default multilib. I compared results using > each of our patches to an unpatched sh-tdep.c. Thanks, and I will likewise do such testing in the next days. > Here are the FAILs that my patch fixed. There are 246 of them. [...] >=20 > Here is a list of FAILs that my patch introduced (regressions). There > are 9 of them: [...] > Here are the FAILs that your patch fixed. There are 127 of them. [...] > Your patch did not introduce any regressions. > So my testing showed that my patch fixed more failures, but introduced > regressions. I find it conceivable, however, that my patch might not > fare as well on some other target. (That's what your testing > demonstrates, right?) Yeah, apparently. > > tbreak add_charest > > Temporary breakpoint 10 at 0x400720: file /scratch/tschwing/FM_sh-l= inux-gnu/src/gdb-mainline/gdb/testsuite/gdb.base/store.c, line 14. > > So the ``tbreak add_charest'' chose line 14 instead of 15. >=20 > I took a look at this regression. [...] Many thanks for the analysis (omitted here) as well as your comments to my comments; I will go throught this in the next days. So, we do seem to agree that something like the patch I posted initially (and as it is incorporated in a similar fashion in your patch, too) does already move us forward; is it reasonable that we commit that one now, and then continue to look on how to further improve the situation based on your patch? This will let us point out more easily which are the additional cases your patch improves/regresses on. (I'd offer to port your patch over to the new baseline, if you want me to.) Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 489 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJPQnG6AAoJENuKOtuXzphJ1GwIALK061g4blycFsWLrqIynycD 9vQDRdRCUlgmhqv5SdYJj6pppg5EDpGeUewhEQ5ZXvT3F/G2uZucb+lb2iUGa3n/ UY1gctlOU+UCB1siywF34mjPPQ07YNDLksNsKvbeDvEFtBnCzWRciTvkOtKwaiOX DxG2zkgd0qBEp+yeF77z9oRct7FVt42Tk2FPKS8YBu7l1rKH52uN1xIr4y/b9Z+V FgvquljnLi9kvDlGO0odZdo8csk4EIzKOmg+WLzadXi0TSKv0ixKhNGuC2gxjWgg SsFx3yEHLJgfwB7g8E6L/tY1O4zBNlVkxXFZTSBgy1s69KRtuwd8OY4NIlkVrJ4= =MxR2 -----END PGP SIGNATURE----- --=-=-=--