From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13042 invoked by alias); 26 Mar 2012 18:27:00 -0000 Received: (qmail 13034 invoked by uid 22791); 26 Mar 2012 18:26:59 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Mar 2012 18:26:45 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2QIQWMj022504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Mar 2012 14:26:45 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2QGXD7H000909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 26 Mar 2012 12:33:13 -0400 From: Tom Tromey To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" Subject: Re: [RFA 3/3] Linespec rewrite: New tests References: <4F67A3B3.6030500@redhat.com> Date: Mon, 26 Mar 2012 18:27:00 -0000 In-Reply-To: <4F67A3B3.6030500@redhat.com> (Keith Seitz's message of "Mon, 19 Mar 2012 14:22:59 -0700") Message-ID: <87mx73s4om.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00872.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> This final patch, also dealing with testing, introduces several new Keith> tests. While one or two of these add tests for new features, several Keith> just add missing tests, like "break ::foo" (surprisingly /not/ tested Keith> today). This looks pretty good. If these tests all pass against CVS gdb, I think this could go in independently of the rewrite patch. Keith> +set base "ls-dollar" Keith> +set srcfile "$base.cc" Keith> +set testfile "$base.exp" Keith> +set exefile $base Keith> + Keith> +if {[skip_cplus_tests]} { Keith> + unsupported linespec.exp Wrong text in the argument here. I think the new trend, proposed in the not-too-distant past by Pedro (IIRC), is to put some useful text in there instead of just the .exp name, since that is redundant anyhow. Keith> +set base ls-errs Keith> +set srcfile "$base.c" Keith> +set testfile "$base.exp" Keith> +set exefile $base Keith> + Keith> +if {[skip_cplus_tests]} { Keith> + unsupported linespec.exp Wrong text -- but there doesn't seem to be a need to examine skip_cplus_tests here at all. Tom