From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7159 invoked by alias); 28 Mar 2012 16:55:35 -0000 Received: (qmail 7150 invoked by uid 22791); 28 Mar 2012 16:55:33 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Mar 2012 16:55:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2SGtESL021375 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Mar 2012 12:55:14 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q2SGtD61001844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 28 Mar 2012 12:55:13 -0400 From: Tom Tromey To: Siddhesh Poyarekar Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [PATCH] Allow 64-bit enum values References: <20120220132724.GB4753@spoyarek.pnq.redhat.com> <87d397syts.fsf@fleche.redhat.com> <20120229135148.GA32128@spoyarek.pnq.redhat.com> <20120301224428.GA30631@host2.jankratochvil.net> <20120305063542.GA30196@spoyarek.pnq.redhat.com> <20120305080512.GA12311@host2.jankratochvil.net> <20120321100630.GA14496@spoyarek.pnq.redhat.com> Date: Wed, 28 Mar 2012 16:55:00 -0000 In-Reply-To: <20120321100630.GA14496@spoyarek.pnq.redhat.com> (Siddhesh Poyarekar's message of "Wed, 21 Mar 2012 15:36:32 +0530") Message-ID: <87mx701x8u.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00945.txt.bz2 >>>>> "Siddhesh" == Siddhesh Poyarekar writes: Siddhesh> I took a separate approach from the one I took in: Siddhesh> http://sourceware.org/ml/gdb-patches/2012-02/msg00403.html Siddhesh> and removed the overloaded meaning of the bitpos location variable to Siddhesh> fix PR symtab/7259. In the following patch, I introduce a separate Siddhesh> field_location union member 'enumval' which can accept LONGEST and Siddhesh> hence expand enum values to 64-bit signed values. With this change, Siddhesh> bitpos now only is used for (non-negative) offsets into structures, Siddhesh> since the other overload of bitpos (range bounds) were already Siddhesh> separated into struct range_bound. I think this also needs an update in py-type.c:convert_field. Tom