From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90479-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29866 invoked by alias); 27 Apr 2012 16:05:33 -0000
Received: (qmail 29854 invoked by uid 22791); 27 Apr 2012 16:05:32 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 16:05:07 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3RG4sbF010351	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 27 Apr 2012 12:04:54 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3RG4qYo027984	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 27 Apr 2012 12:04:53 -0400
From: Tom Tromey <tromey@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Emit a warning for ineffective set VAR = EXP command
References: <8781499A-A489-42D0-80B1-75136331DBDB@adacore.com>
Date: Fri, 27 Apr 2012 16:09:00 -0000
In-Reply-To: <8781499A-A489-42D0-80B1-75136331DBDB@adacore.com> (Tristan	Gingold's message of "Fri, 27 Apr 2012 15:28:30 +0200")
Message-ID: <87mx5x40uz.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg01014.txt.bz2

>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:

Tristan> I simply propose to emit a warning if the expression is not an
Tristan> assignment (or a comma expression).

It seems reasonable to me.

Tristan> Ok for trunk ?

I think there should be a test case.

Tom