From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30681 invoked by alias); 5 Jul 2012 18:01:15 -0000 Received: (qmail 30673 invoked by uid 22791); 5 Jul 2012 18:01:15 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Jul 2012 18:00:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q65I0vr7025580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Jul 2012 14:00:57 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q65I0u10009679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 5 Jul 2012 14:00:56 -0400 From: Tom Tromey To: "Metzger\, Markus T" Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH 2/2] Implement operator new References: <87ehostvf4.fsf@fleche.redhat.com> Date: Thu, 05 Jul 2012 18:01:00 -0000 In-Reply-To: (Markus T. Metzger's message of "Wed, 4 Jul 2012 08:55:55 +0000") Message-ID: <87mx3erstj.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00076.txt.bz2 >>>>> "Markus" == Metzger, Markus T writes: Markus> New also accepts a braced-init-list, i.e. with {} instead of (). I found a number of other cases that this patch doesn't correctly handle. I'm not going to put it in until I fix them all. I'll look at braced initializers. >> + sym = lookup_symbol ("__aeabi_vec_ctor_cookie_nodtor", >> + NULL, VAR_DOMAIN, NULL); >> + if (sym != NULL) >> + { >> + /* ARM EABI has an extra slot. */ >> + *include_size = 1; >> + multiplier = 2; >> + } >> + else >> + *include_size = 0; Markus> Shouldn't we be able to query the ABI from the ELF? I don't know how. Tom