From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10680 invoked by alias); 23 Jul 2012 15:23:10 -0000 Received: (qmail 10672 invoked by uid 22791); 23 Jul 2012 15:23:09 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jul 2012 15:22:52 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6NFMqs4003776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Jul 2012 11:22:52 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6NFMoPJ005340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Jul 2012 11:22:51 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/10] change gdb to refcount bfd everywhere References: <87vchk3lxs.fsf@fleche.redhat.com> <20120719141750.GB23801@host2.jankratochvil.net> <877gtzxyck.fsf@fleche.redhat.com> <87sjcmv16h.fsf@fleche.redhat.com> <20120723085355.GA29593@host2.jankratochvil.net> <20120723090609.GA32703@host2.jankratochvil.net> Date: Mon, 23 Jul 2012 15:23:00 -0000 In-Reply-To: <20120723090609.GA32703@host2.jankratochvil.net> (Jan Kratochvil's message of "Mon, 23 Jul 2012 11:06:09 +0200") Message-ID: <87mx2qqz79.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00451.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> And solib-svr4.c enable_break IMO leaks tmp_bfd. Thanks for catching this. Here is the patch. Tom 2012-07-23 Tom Tromey * solib-svr4.c (enable_break): Update. * bfd-target.h (target_bfd_reopen): Update documentation. diff --git a/gdb/bfd-target.h b/gdb/bfd-target.h index 71001c5..7f4e628 100644 --- a/gdb/bfd-target.h +++ b/gdb/bfd-target.h @@ -23,9 +23,9 @@ struct bfd; struct target_ops; -/* Given an existing BFD, re-open it as a "struct target_ops". On - close, it will also close the corresponding BFD (which is like - freopen and fdopen). */ +/* Given an existing BFD, re-open it as a "struct target_ops". This + acquires a new reference to the BFD. This reference will be + released when the target is closed. */ struct target_ops *target_bfd_reopen (struct bfd *bfd); #endif diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c index 307e483..b636b71 100644 --- a/gdb/solib-svr4.c +++ b/gdb/solib-svr4.c @@ -1558,9 +1558,11 @@ enable_break (struct svr4_info *info, int from_tty) goto bkpt_at_symbol; /* Now convert the TMP_BFD into a target. That way target, as - well as BFD operations can be used. Note that closing the - target will also close the underlying bfd. */ + well as BFD operations can be used. */ tmp_bfd_target = target_bfd_reopen (tmp_bfd); + /* target_bfd_reopen acquired its own reference, so we can + release ours now. */ + gdb_bfd_unref (tmp_bfd); /* On a running target, we can get the dynamic linker's base address from the shared library table. */ @@ -1670,8 +1672,9 @@ enable_break (struct svr4_info *info, int from_tty) sym_addr, tmp_bfd_target); - /* We're done with both the temporary bfd and target. Remember, - closing the target closes the underlying bfd. */ + /* We're done with both the temporary bfd and target. Closing + the target closes the underlying bfd, because it holds the + only remaining reference. */ target_close (tmp_bfd_target, 0); if (sym_addr != 0)