Re: gdb-7.5 branch ready for first release?

Ralf Corsepius
2012-08-09T04:44:23Z

On 08/08/2012 10:46 PM, Tom Tromey wrote:
>>>>>> "Ralf" == Ralf Corsepius <ralf.corsepius@googlemail.com> writes:
>
> Ralf> Would such a patch be acceptable or is using inttypes.h/stdint.h being
> Ralf> considered a "no-go"?
>
> I can't speak to the sim changes.
>
> For this one:
>
> Ralf> diff --git a/gdb/symfile.c b/gdb/symfile.c
> Ralf> index 01252e2..01720fa 100644
> Ralf> --- a/gdb/symfile.c
> Ralf> +++ b/gdb/symfile.c
> Ralf> @@ -2889,8 +2889,8 @@ allocate_symtab (const char *filename, struct objfile *objfile)
> Ralf> last_objfile_name);
> Ralf> }
> Ralf> fprintf_unfiltered (gdb_stdlog,
> Ralf> - "Created symtab 0x%lx for module %s.\n",
> Ralf> - (long) symtab, filename);
> Ralf> + "Created symtab 0x%p for module %s.\n",
> Ralf> + symtab, filename);
> Ralf> }
>
> Rather than %p I think it is the norm in gdb to use %s with
> host_address_to_string.

OK, thanks for the pointer. I'll try to take this into account when
revisiting this issue next time [1].

Ralf

[1] Due to vaction, this is unlikely to happen before Aug 20 ;)