From: Tom Tromey <tromey@redhat.com>
To: Dmitry Kozlov <dmitry_kozlov@mentor.com>
Cc: <gdb-patches@sourceware.org>,
"'Stan_Shebs\@mentor.com'" <Stan_Shebs@mentor.com>,
Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: PATCH fix start-time and stop-time in trace-status
Date: Mon, 15 Oct 2012 19:11:00 -0000 [thread overview]
Message-ID: <87mwzna6u3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50699D74.2090401@mentor.com> (Dmitry Kozlov's message of "Mon, 1 Oct 2012 17:41:08 +0400")
>>>>> "Dmitry" == Dmitry Kozlov <dmitry_kozlov@mentor.com> writes:
Dmitry> +2012-10-01 Dmitry Kozlov <ddk@mentor.com>
Dmitry> +
Dmitry> + * tracepoint.c (trace_status_command): Fix type of printf arg.
Dmitry> + (trace_status_mi): Likewise.
Looks pretty good.
Dmitry> + val = strtoulst(++p1, (const char **) &p, 10);
Space before open paren.
Dmitry> + val = strtoulst(++p1, (const char **) &p, 10);
Likewise.
This is ok with these fixed.
Tom
next prev parent reply other threads:[~2012-10-15 19:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 12:22 Dmitry Kozlov
2012-09-27 15:14 ` Tom Tromey
2012-10-01 13:41 ` Dmitry Kozlov
2012-10-15 19:11 ` Tom Tromey [this message]
2012-10-16 14:59 ` Dmitry Kozlov
2012-10-16 15:15 ` Pedro Alves
2012-10-16 17:07 ` Stan Shebs
2012-10-16 16:51 ` Tom Tromey
2012-10-08 13:54 ` Dmitry Kozlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwzna6u3.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Stan_Shebs@mentor.com \
--cc=dmitry_kozlov@mentor.com \
--cc=gdb-patches@sourceware.org \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox