From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21725 invoked by alias); 15 Nov 2012 19:25:05 -0000 Received: (qmail 21712 invoked by uid 22791); 15 Nov 2012 19:25:04 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 19:24:59 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAFJOx0N005766 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 15 Nov 2012 14:24:59 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAFJOvi9031763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 15 Nov 2012 14:24:58 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [4/10] RFC: unconditionally include signal.h References: <87obiyzns7.fsf@fleche.redhat.com> Date: Thu, 15 Nov 2012 19:25:00 -0000 In-Reply-To: <87obiyzns7.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 15 Nov 2012 12:09:12 -0700") Message-ID: <87mwyiy8hi.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00426.txt.bz2 I think that checking for signal.h is pointless, because gdb already includes it unconditionally in various places -- e.g., utils.c. This patch removes the useless check and updates the few spots that were using HAVE_SIGNAL_H. Tom * configure.ac: Don't check for signal.h. * config.in: Rebuild. * configure: Rebuild. * common/signals.c: Update. * configure.ac: Don't check for signal.h. * config.in: Rebuild. * configure: Rebuild. * gdbreplay.c: Update. * remote-utils.c: Update. * server.c: Update. --- gdb/common/signals.c | 2 -- gdb/config.in | 3 --- gdb/configure | 2 +- gdb/configure.ac | 2 +- gdb/gdbserver/config.in | 3 --- gdb/gdbserver/configure | 2 +- gdb/gdbserver/configure.ac | 2 +- gdb/gdbserver/gdbreplay.c | 2 -- gdb/gdbserver/remote-utils.c | 2 -- gdb/gdbserver/server.c | 2 -- 10 files changed, 4 insertions(+), 18 deletions(-) diff --git a/gdb/common/signals.c b/gdb/common/signals.c index 4ab863c..4541c8e 100644 --- a/gdb/common/signals.c +++ b/gdb/common/signals.c @@ -24,9 +24,7 @@ #include #endif -#ifdef HAVE_SIGNAL_H #include -#endif #include "gdb_signals.h" diff --git a/gdb/configure.ac b/gdb/configure.ac index 28291ff..58f715b 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1074,7 +1074,7 @@ fi AC_HEADER_STDC # elf_hp.h is for HP/UX 64-bit shared library support. AC_CHECK_HEADERS([nlist.h machine/reg.h poll.h sys/poll.h proc_service.h \ - thread_db.h signal.h stddef.h \ + thread_db.h stddef.h \ stdlib.h sys/fault.h \ sys/file.h sys/filio.h sys/ioctl.h sys/param.h \ sys/resource.h sys/procfs.h sys/ptrace.h ptrace.h \ diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac index 9b364ff..ecbb921 100644 --- a/gdb/gdbserver/configure.ac +++ b/gdb/gdbserver/configure.ac @@ -52,7 +52,7 @@ ACX_CONFIGURE_DIR(["../gnulib"], ["build-gnulib-gdbserver"]) AC_CHECK_HEADERS(sgtty.h termio.h termios.h sys/reg.h dnl proc_service.h sys/procfs.h thread_db.h linux/elf.h dnl stdlib.h unistd.h dnl - errno.h fcntl.h signal.h sys/file.h malloc.h dnl + errno.h fcntl.h sys/file.h malloc.h dnl sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl netinet/tcp.h arpa/inet.h sys/wait.h wait.h sys/un.h) AC_CHECK_FUNCS(pread pwrite pread64 readlink) diff --git a/gdb/gdbserver/gdbreplay.c b/gdb/gdbserver/gdbreplay.c index 6034d93..2a48c04 100644 --- a/gdb/gdbserver/gdbreplay.c +++ b/gdb/gdbserver/gdbreplay.c @@ -25,9 +25,7 @@ #if HAVE_SYS_FILE_H #include #endif -#if HAVE_SIGNAL_H #include -#endif #include #if HAVE_FCNTL_H #include diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c index adc8783..6f5d7ef 100644 --- a/gdb/gdbserver/remote-utils.c +++ b/gdb/gdbserver/remote-utils.c @@ -43,9 +43,7 @@ #if HAVE_SYS_IOCTL_H #include #endif -#if HAVE_SIGNAL_H #include -#endif #if HAVE_FCNTL_H #include #endif diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index fae9199..b08f1ba 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -24,9 +24,7 @@ #if HAVE_UNISTD_H #include #endif -#if HAVE_SIGNAL_H #include -#endif #include "gdb_wait.h" /* The thread set with an `Hc' packet. `Hc' is deprecated in favor of -- 1.7.7.6