From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99507-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4199 invoked by alias); 13 Mar 2013 17:43:26 -0000
Received: (qmail 4190 invoked by uid 22791); 13 Mar 2013 17:43:25 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 17:43:18 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DHhHCf023862	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 13 Mar 2013 13:43:17 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2DHhGvo031534	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 13 Mar 2013 13:43:17 -0400
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA PATCH] Fix completer.c FIXME, and invalid pointer to pointer conversion.
References: <20130313165042.26289.16370.stgit@brno.lan>
Date: Wed, 13 Mar 2013 17:43:00 -0000
In-Reply-To: <20130313165042.26289.16370.stgit@brno.lan> (Pedro Alves's	message of "Wed, 13 Mar 2013 16:50:42 +0000")
Message-ID: <87mwu7b3gr.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00583.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> This patch removes all that dead code, then makes
Pedro> current_demangling_style_string point to an element of
Pedro> demangling_style_names, as the FIXME suggests, and then makes
Pedro> current_demangling_style_string, removing the need for the 'const char
Pedro> **' cast.

Looks good to me.

Tom