Re: [PATCH 01/22] [GDBserver] Multi-process + multi-arch: core + GNU/Linux x86*

Tom Tromey
2013-05-29T19:03:31Z

Pedro> diff --git a/gdb/gdbserver/linux-amd64-ipa.c b/gdb/gdbserver/linux-amd64-ipa.c
Pedro> index dc20a15..d0c40c9 100644
Pedro> --- a/gdb/gdbserver/linux-amd64-ipa.c
Pedro> +++ b/gdb/gdbserver/linux-amd64-ipa.c
Pedro> @@ -23,6 +23,9 @@
Pedro> /* Defined in auto-generated file amd64-linux.c. */
Pedro> void init_registers_amd64_linux (void);

Pedro> +/* Ditto. */
Pedro> +extern struct target_desc *tdesc_amd64_linux;

It seems like this (and other instances) could be const.

Pedro> struct reg *
Pedro> -find_register_by_name (const char *name)
Pedro> +find_register_by_name (struct target_desc *tdesc, const char *name)

How about const here?

Pedro> int
Pedro> -find_regno (const char *name)
Pedro> +find_regno (struct target_desc *tdesc, const char *name)

And here and other similar spots?

Pedro> +struct target_desc
Pedro> +{
Pedro> + /* An array of NUM_REGISTERS elements of register definitions that
Pedro> + description the inferior's register set. */
Pedro> + struct reg *reg_defs;

I think it should be "...that describe...".

Tom