From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14493 invoked by alias); 29 May 2013 19:03:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14469 invoked by uid 89); 29 May 2013 19:03:28 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 19:03:28 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TJ3Q9I029536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 15:03:26 -0400 Received: from barimba (ovpn-113-72.phx2.redhat.com [10.3.113.72]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4TJ3P07027955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 29 May 2013 15:03:26 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/22] [GDBserver] Multi-process + multi-arch: core + GNU/Linux x86* References: <20130529162434.24586.5697.stgit@brno.lan> <20130529162452.24586.9557.stgit@brno.lan> Date: Wed, 29 May 2013 19:03:00 -0000 In-Reply-To: <20130529162452.24586.9557.stgit@brno.lan> (Pedro Alves's message of "Wed, 29 May 2013 17:24:52 +0100") Message-ID: <87mwrdtxqa.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg01033.txt.bz2 Pedro> diff --git a/gdb/gdbserver/linux-amd64-ipa.c b/gdb/gdbserver/linux-amd64-ipa.c Pedro> index dc20a15..d0c40c9 100644 Pedro> --- a/gdb/gdbserver/linux-amd64-ipa.c Pedro> +++ b/gdb/gdbserver/linux-amd64-ipa.c Pedro> @@ -23,6 +23,9 @@ Pedro> /* Defined in auto-generated file amd64-linux.c. */ Pedro> void init_registers_amd64_linux (void); Pedro> +/* Ditto. */ Pedro> +extern struct target_desc *tdesc_amd64_linux; It seems like this (and other instances) could be const. Pedro> struct reg * Pedro> -find_register_by_name (const char *name) Pedro> +find_register_by_name (struct target_desc *tdesc, const char *name) How about const here? Pedro> int Pedro> -find_regno (const char *name) Pedro> +find_regno (struct target_desc *tdesc, const char *name) And here and other similar spots? Pedro> +struct target_desc Pedro> +{ Pedro> + /* An array of NUM_REGISTERS elements of register definitions that Pedro> + description the inferior's register set. */ Pedro> + struct reg *reg_defs; I think it should be "...that describe...". Tom