Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch][python] Fix python/14513
Date: Mon, 21 Oct 2013 21:58:00 -0000	[thread overview]
Message-ID: <87mwm2i8vi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <524BE7B3.3030805@redhat.com> (Phil Muldoon's message of "Wed, 02	Oct 2013 10:30:27 +0100")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> I am not sure what the resolution is here.  At some point we have to
Phil> decide whether we have anything valid to print.  We can hoist the
Phil> fprint into both of these branches, but even in the "else" clause we
Phil> have to check if we actually have anything as the fprint adds a
Phil> newline to the set documentation:

Phil> fprintf_filtered (gdb_stdout, "%s\n", set_doc_string);

Phil> What are your thoughts on this?

I've been thinking about it more and I don't understand why we want to
print anything in the "set" command.
I think it's fine if we just don't call a method.
What do you think of that?

Tom


  reply	other threads:[~2013-10-21 21:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18 13:17 Phil Muldoon
2013-09-18 20:26 ` Tom Tromey
2013-09-18 20:34   ` Phil Muldoon
2013-09-18 20:40     ` Tom Tromey
2013-10-02  9:30       ` Phil Muldoon
2013-10-21 21:58         ` Tom Tromey [this message]
2013-10-30  9:01           ` Phil Muldoon
2013-11-08  3:18             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwm2i8vi.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox