From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-109098-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29789 invoked by alias); 10 Jan 2014 21:45:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29779 invoked by uid 89); 10 Jan 2014 21:45:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2014 21:45:42 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0ALjdnI018547	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 10 Jan 2014 16:45:40 -0500
Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0ALjcrI013969	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 10 Jan 2014 16:45:39 -0500
From: Tom Tromey <tromey@redhat.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] Fix for D demangling in GDB
References: <CABOHX+fr7hyD0WM-=1G4zcoJH61uPiE9ezYSYmKuUoqvZnLmvA@mail.gmail.com>	<87zjn47ref.fsf@fleche.redhat.com>	<CABOHX+dXQQjpE2-S3wM5Qcrq=i29HewDzRptXcrn0=T+EVjOrg@mail.gmail.com>	<CABOHX+e2pJ6eM0_29iQ6QEDhB43x9iN8u+6ROTXfn9NBYLnrQw@mail.gmail.com>
Date: Fri, 10 Jan 2014 21:45:00 -0000
In-Reply-To: <CABOHX+e2pJ6eM0_29iQ6QEDhB43x9iN8u+6ROTXfn9NBYLnrQw@mail.gmail.com>	(Iain Buclaw's message of "Fri, 10 Jan 2014 15:05:31 +0000")
Message-ID: <87mwj34ikd.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-01/txt/msg00300.txt.bz2

>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:

Iain> Second change, move D demangling routines out of d-lang.c into
Iain> d-support.c, which is intended to house other language support
Iain> functions that don't really have a home elsewhere.

Thanks.

Iain>         * d-lang.c (parse_call_convention)
Iain>         (parse_attributes, parse_function_types)
Iain>         (parse_function_args, parse_type, parse_identifier)
Iain>         (call_convention_p, d_parse_symbol): Move functions to ...
Iain>         * d-support.c: ... New file.

This should mention the Makefile.in change, like:

	* Makefile.in (SFILES): Add d-support.c.
        (COMMON_OBS): Add d-support.o.

... and the d-lang.h change, even though it is trivial.

Otherwise the patch is fine.

Tom