From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-113777-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18008 invoked by alias); 24 Jun 2014 13:18:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 17998 invoked by uid 89); 24 Jun 2014 13:18:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 Jun 2014 13:18:55 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5ODIo8W017545	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Tue, 24 Jun 2014 09:18:51 -0400
Received: from barimba (ovpn-113-138.phx2.redhat.com [10.3.113.138])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5ODInM6008150	(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO);	Tue, 24 Jun 2014 09:18:50 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] constify search_symbols
References: <1403285060-5556-1-git-send-email-tromey@redhat.com>	<53A8EC05.2030901@codesourcery.com>
Date: Tue, 24 Jun 2014 13:18:00 -0000
In-Reply-To: <53A8EC05.2030901@codesourcery.com> (Yao Qi's message of "Tue, 24	Jun 2014 11:09:57 +0800")
Message-ID: <87mwd24f9j.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-06/txt/msg00849.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> file_name isn't used out side of this block, so we can define file_name
Yao> within this block of type "char *", and patch can be shorter.

The problem is that we need to set "file_names = &file_name", and you
can't take the address of a "char *" and cast that to "const char **".

Tom