From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31353 invoked by alias); 17 Oct 2014 05:52:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31343 invoked by uid 89); 17 Oct 2014 05:52:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 17 Oct 2014 05:52:55 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s9H5qnUg000784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Oct 2014 05:52:49 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9H5qm5Z001000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 17 Oct 2014 05:52:49 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9H5qlHU010488; Fri, 17 Oct 2014 05:52:47 GMT Received: from termi.oracle.com (/87.189.161.156) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 16 Oct 2014 22:52:47 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Sergio Durigan Junior Cc: Pedro Alves , Doug Evans , gdb-patches@sourceware.org Subject: Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'. References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com> <21560.22449.803178.90104@ruffy2.mtv.corp.google.com> <878uknun2f.fsf@oracle.com> <5440649C.6080705@redhat.com> <87mw8vfrb0.fsf@redhat.com> Date: Fri, 17 Oct 2014 05:52:00 -0000 In-Reply-To: <87mw8vfrb0.fsf@redhat.com> (Sergio Durigan Junior's message of "Thu, 16 Oct 2014 20:55:31 -0400") Message-ID: <87mw8vnspz.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00455.txt.bz2 > Shouldn't we explicitly say which probe is stap, vs dprobe (vs whatever > other probe type)? Like, either a new column: This is actually a nice idea, and if I say that I thought about it while testing the patch, but then forgot to mention, would it seem strange? :-) Noooo ;) I like the idea of having a new column with the type. I will add an extra patch to the patch series.