Re: [PATCH obv/pushed] MIPS ptrace build fixes

Pedro Alves
2015-07-29T21:59:52Z

On 07/29/2015 10:26 PM, Simon Marchi wrote:
> On 15-07-29 05:19 PM, Simon Marchi wrote:
>> FYI, I am pushing this as obvious.
>>
>> Since Pedro's ptrace cleanups, the MIPS buildbot compilation fails.

In my defense, I did get a build fail email report, but it points at:

http://gdb-build.sergiodj.net/builders/Debian-MIPS-m64/builds/77

and looking at:

http://gdb-build.sergiodj.net/builders/Debian-MIPS-m64/builds/77/steps/compile%20gdb/logs/stdio

it shows the build had failed for an unrelated issue:

tdep.Tpo ../../binutils-gdb/gdb/i386obsd-tdep.c
In file included from ../../binutils-gdb/gdb/common/common-defs.h:32:0,
from ../../binutils-gdb/gdb/defs.h:28,
from ../../binutils-gdb/gdb/i386obsd-tdep.c:20:
build-gnulib/import/stdlib.h:41:20: fatal error: /usr/lib/gcc/mips-linux-gnu/4.9/include/ctddef.h: No such file or directory
#include <stddef.h>
^
compilation terminated.
The bug is not reproducible, so it is likely a hardware or OS problem.
make[2]: *** [i386obsd-tdep.o] Error 1
Makefile:1133: recipe for target 'i386obsd-tdep.o' failed

So I just ignored it. Guess I was "lucky".

>> Code in MIPS native uses ptrace with 3 arguments, where ptrace requires
>> 4. When looking at the definition of ptrace in
>> /usr/include/sys/ptrace.h, it shows that it takes a variable number of
>> arguments. The wrapper macro in nat/gdb_ptrace.h takes a fixed number
>> of arguments (4). That would explain why it used to work and stopped.
>>
>> I am pushing this as obvious, tell me if there is any problem.

Yes, that's the right fix:
https://sourceware.org/ml/gdb-patches/2015-07/msg00721.html

> Also, I cancelled the current build as well as all pending builds before this commit
> on the MIPS builder, in case you were wondering where they all went. There is no
> point in spending over 24 hours building code we know won't build.

Thanks.

--
Pedro Alves