From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45634 invoked by alias); 12 Oct 2016 02:12:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45457 invoked by uid 89); 12 Oct 2016 02:12:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=sk:number_, Hx-languages-length:1004, H*RU:67.222.38.55, HX-HELO:sk:gproxy5 X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 12 Oct 2016 02:12:06 +0000 Received: (qmail 12120 invoked by uid 0); 12 Oct 2016 02:12:04 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy5.mail.unifiedlayer.com with SMTP; 12 Oct 2016 02:12:04 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id uSBz1t00P2f2jeq01SC2Jn; Tue, 11 Oct 2016 20:12:02 -0600 X-Authority-Analysis: v=2.1 cv=beT4Do/B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=4ps8DiAggNSBWW7XH9IA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:51844 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bu91U-00016Y-OR; Tue, 11 Oct 2016 20:12:00 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 19/22] Convert tid_range_parser to class References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-20-git-send-email-tom@tromey.com> <55f2924c-f8f9-6c06-ffbb-69079b6ffa62@redhat.com> <87shsha3bf.fsf@tromey.com> <926126cb-b3c5-340b-ac1c-5bc14ca41bf9@redhat.com> <42bd9696-cea5-5f39-ce03-1b223b5ed6fc@redhat.com> <5cae4120-3581-b3ca-b323-44d8788e2916@redhat.com> Date: Wed, 12 Oct 2016 02:12:00 -0000 In-Reply-To: <5cae4120-3581-b3ca-b323-44d8788e2916@redhat.com> (Pedro Alves's message of "Wed, 5 Oct 2016 00:09:13 +0100") Message-ID: <87mvianwnl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bu91U-00016Y-OR X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:51844 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00283.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Here's what I ended up with, after reading your version in more Pedro> detail. That brought in the "deleted" copy Pedro> constructor/assignment operators [1], and "const" in several Pedro> methods, which I then propagated to number_or_range_parser too. Pedro> WDYT? I'm sorry I didn't reply to this sooner. This all looks good to me. Pedro> [1] - I'm pondering making those use =delete if compiling with Pedro> a C++ compiler, behind some Pedro> #define DISABLE_COPY_AND_ASSIGN(TYPE) ... Pedro> macro. Pedro> Or, maybe add a gdb::noncopyable class that non-copyable Pedro> classes inherit from privately, just like boost:noncopyable. Pedro> Anyone got experience on the latter, and whether that turns Pedro> out to be a bad idea? I haven't used that. The Moz approach that Trevor mentioned seems reasonable. Or, just switching to C++11, per the other thread, and using =delete. Tom