From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109974 invoked by alias); 12 Nov 2016 17:04:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109960 invoked by uid 89); 12 Nov 2016 17:04:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:493, H*F:U*tom X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Sat, 12 Nov 2016 17:04:37 +0000 Received: (qmail 8658 invoked by uid 0); 12 Nov 2016 17:04:35 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy5.mail.unifiedlayer.com with SMTP; 12 Nov 2016 17:04:35 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 754Y1u00s2f2jeq0154bFV; Sat, 12 Nov 2016 10:04:35 -0700 X-Authority-Analysis: v=2.1 cv=WL/sABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=20KFwNOVAAAA:8 a=yIABZGa69SJ9UrL-qZMA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:35430 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c5bjE-0002A6-EP; Sat, 12 Nov 2016 10:04:32 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 14/20] Use gdbpy_enter in gdbpy_before_prompt_hook References: <1478816387-27064-1-git-send-email-tom@tromey.com> <1478816387-27064-15-git-send-email-tom@tromey.com> Date: Sat, 12 Nov 2016 17:04:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 10 Nov 2016 23:19:23 +0000") Message-ID: <87mvh4iq91.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1c5bjE-0002A6-EP X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:35430 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-11/txt/msg00307.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> if (prompt != NULL) >> set_prompt (prompt.get ()); Pedro> I haven't applied the patch locally, but I suspect this set_prompt call Pedro> could move to the tail of the nested ifs, where you could Pedro> return EXT_LANG_RC_OK unconditionally, and then the bottom Pedro> could just unconditionally return EXT_LANG_RC_NOP. Yes, that's correct. I'm making this change. Tom