From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99255 invoked by alias); 10 Sep 2017 16:12:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98926 invoked by uid 89); 10 Sep 2017 16:12:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Sep 2017 16:12:21 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D3F3D207BF2; Sun, 10 Sep 2017 16:12:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D3F3D207BF2 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A8BB75C548; Sun, 10 Sep 2017 16:12:19 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Yao Qi Subject: Re: [PATCH] Fix build breakage on GNU/Linux AArch64 and use std::vector on tdesc.reg_defs References: <20170910055056.21186-1-sergiodj@redhat.com> <41ee3f9801392370c02481e2f77aa8dc@polymtl.ca> Date: Sun, 10 Sep 2017 16:12:00 -0000 In-Reply-To: <41ee3f9801392370c02481e2f77aa8dc@polymtl.ca> (Simon Marchi's message of "Sun, 10 Sep 2017 11:02:35 +0200") Message-ID: <87mv62o7mk.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00271.txt.bz2 On Sunday, September 10 2017, Simon Marchi wrote: > On 2017-09-10 07:50, Sergio Durigan Junior wrote: >> This patch fixes the build breakage that has been happening on AArch64 >> since September 5th. The breakage was introduced by the following >> commit: >> >> author Yao Qi >> Tue, 5 Sep 2017 04:54:52 -0400 (09:54 +0100) >> committer Yao Qi >> Tue, 5 Sep 2017 04:54:52 -0400 (09:54 +0100) >> commit f7000548a2b79d7e5cb924468117ca4245e6b820 >> >> Use VEC for target_desc.reg_defs >> >> The build log for this commit can be seen here: >> >> >> >> >> And the underlying problem is that the code is not calling the new >> function "allocate_target_description" to allocate the "struct >> target_desc" using "new" instead of XNEW, which end up not properly >> initializing the fields of the structure. >> >> I took the opportunity to convert the code to std::vector (instead of >> VEC), which makes things even simpler. This has been regtested on the >> BuildBot, without regressions, and fixes the build breakage. > > Hi Sergio, > > This patch seems to do two independent changes: > > - use allocate_target_description instead of XNEW > - replace VEC with std::vector > > Can you post separate patches? You can push the first one directly, I > would call it obvious (and it's the important bits to fix the build). > The second one, Yao might want to take a look. Sure thing, I'll split it and resubmit. Thanks. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/