Re: [RFA 00/67] Simple add_cmd constification

Pedro Alves
2017-09-21T10:26:54Z

On 09/21/2017 06:09 AM, Tom Tromey wrote:
> First, left me offer my apologies for the length of this series. It
> was somewhat simpler to break it into many tiny pieces, because
> sometimes when const-ifying it is easy to get in over one's head. On
> the plus side, nearly all of the patches are trivial and so review
> should not be too difficult -- just boring.
>
> This starts by adding const-correct overloads of add_cmd and a few
> related functions. Then, it converts many functions to use the
> const-correct form. The idea is to gradually convert all commands
> (and set/show, etc) to const-correctness, then remove the non-const
> overloads.
>
> Regression tested on the buildbot.

I've read the whole series and sent a few comments, but it
all looks generally fine to me. Those patches that I haven't
commented on looked OK as-is to me.

Thanks for doing all this.

Thanks,
Pedro Alves