From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54634 invoked by alias); 3 Nov 2017 16:39:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54577 invoked by uid 89); 3 Nov 2017 16:39:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:456 X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Nov 2017 16:39:00 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 15D804F829 for ; Fri, 3 Nov 2017 11:37:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id AeyHeGjJmtuxmAeyHeeMYR; Fri, 03 Nov 2017 11:37:29 -0500 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:45644 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eAeyG-000naz-RL; Fri, 03 Nov 2017 11:37:28 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 04/13] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-5-tom@tromey.com> Date: Fri, 03 Nov 2017 16:39:00 -0000 In-Reply-To: (Simon Marchi's message of "Thu, 02 Nov 2017 21:02:21 -0400") Message-ID: <87mv431fp4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eAeyG-000naz-RL X-Source-Sender: 71-218-90-63.hlrn.qwest.net (pokyo) [71.218.90.63]:45644 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2017-11/txt/msg00079.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Just one tiny nit: when possible, I like to replace strcmp with Simon> std::string's operator== Simon> if (dir == symlink_dir.get ()) Simon> but I'll leave it up to you. Good idea, I made this change; though I think it should be != due to: > + if (strcmp (dir.c_str (), symlink_dir.get ()) != 0) Tom