From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126643 invoked by alias); 28 Nov 2017 16:36:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126633 invoked by uid 89); 28 Nov 2017 16:36:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=You've, Youve, honour, Hx-languages-length:2140 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Nov 2017 16:36:53 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C621C61461 for ; Tue, 28 Nov 2017 16:36:52 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 968615EDE2; Tue, 28 Nov 2017 16:36:48 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: Sergio Lopez , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command References: <20171128132148.31802-1-slp@redhat.com> <20171128132148.31802-2-slp@redhat.com> <87induo1ey.fsf@redhat.com> Date: Tue, 28 Nov 2017 16:36:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 28 Nov 2017 16:21:36 +0000") Message-ID: <87mv36mkbj.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00738.txt.bz2 On Tuesday, November 28 2017, Pedro Alves wrote: > On 11/28/2017 03:42 PM, Sergio Durigan Junior wrote: > >>> @@ -2517,4 +2522,16 @@ of /proc/PID/coredump_filter when generating the corefile. For more information >>> about this file, refer to the manpage of core(5)."), >>> NULL, show_use_coredump_filter, >>> &setlist, &showlist); >>> + >>> + add_setshow_boolean_cmd ("honor-dontdump-flag", class_files, >>> + &honor_dontdump_flag, _("\ >>> +Set whether gcore should honor the VM_DONTDUMP flag."), >>> + _("\ >>> +Show whether gcore should honor the VM_DONTDUMP flag."), >>> + _("\ >>> +Use this command to set whether gcore should honor the VM_DONTDUMP\n\ >>> +flag from /proc/PID/smaps when generating the corefile. For more information\n\ >>> +about this file, refer to the manpage of proc(5) and core(5)."), >>> + NULL, show_use_coredump_filter, >> >> You've already spotted the mistake of using 'show_use_coredump_filter' >> here. >> >>> + &setlist, &showlist); >> >> I'm not sure "honor-dontdump-flag" is a good name for this setting. >> There's no indication that it relates to coredumps, and I think it >> should. A name like "honor-coredump-dontdump-flag" is a bit repetitive, >> but IMHO is better than just "honor-dontdump-flag". WDYT? > > Personally, I don't find the "coredump" issue that much of a > problem, given "dump" is there. "honor-coredump-dontdump" looks > like a mouthful to me. It is a mouthful, but at least it leaves no room for doubt. The "dump" in the name doesn't necessarily translate to "coredump", I think. Or at least that's what I would feel. > I think using "ignore" in the name would some more natural > in GDB than "honor". I.e., "set ignore-dontdump-flag on/off". > That mean default is off/0 ( and the control variable could go > to .bss :-) ) > > It also avoids our UK friends cursing at bad spelling of "honour". :-) > > "set dump-excluded-mappings on/off" could work too? This one is better IMO. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/