From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129051 invoked by alias); 13 Dec 2017 17:14:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129036 invoked by uid 89); 13 Dec 2017 17:14:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Dec 2017 17:14:17 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBD677EA88; Wed, 13 Dec 2017 17:14:16 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 986E67D929; Wed, 13 Dec 2017 17:14:16 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: gdb-patches@sourceware.org, tom@tromey.com, simon.marchi@ericsson.com, palves@redhat.com, keiths@redhat.com Subject: Re: [PATCH v5 2/2] Implement pahole-like 'ptype /o' option References: <20171121160709.23248-1-sergiodj@redhat.com> <20171213031724.22721-1-sergiodj@redhat.com> <20171213031724.22721-3-sergiodj@redhat.com> <83k1xqvc14.fsf@gnu.org> Date: Wed, 13 Dec 2017 17:14:00 -0000 In-Reply-To: <83k1xqvc14.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 13 Dec 2017 18:16:23 +0200") Message-ID: <87mv2mk0t3.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00318.txt.bz2 On Wednesday, December 13 2017, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Tom Tromey , Eli Zaretskii , Simon >> Marchi , Pedro Alves , >> Keith Seitz , Sergio Durigan Junior >> >> Date: Tue, 12 Dec 2017 22:17:24 -0500 >> >> This commit implements the pahole-like '/o' option for 'ptype', which >> +Issuing a @kbd{ptype /o struct tuv} would print: > ^ > Please insert "command" after the command, where I indicated. > Otherwise the sentence reads awkward. Done. >> +Notice the format of the first column of comments. There, you can >> +find two parts separated by the @code{|} character: the @emph{offset}, > ^^^^^^^^ > @samp, not @code. Fixed. > The documentation parts are okay with these fixed. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/