From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Use std::unique_ptr in dwarf2_read_debug_names
Date: Mon, 21 May 2018 15:52:00 -0000 [thread overview]
Message-ID: <87muwt2f7s.fsf@tromey.com> (raw)
In-Reply-To: <52e98157-98c4-5c73-8e17-338d14d00b55@simark.ca> (Simon Marchi's message of "Sun, 20 May 2018 19:49:51 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> We maybe could add DISABLE_COPY_AND_ASSIGN to mapped_index_base, to ensure
Simon> we don't make copies of mapped_index/mapped_debug_names by mistake.
I also needed to default the no-arg constructor.
I'm checking it in with the appended addition.
Tom
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 9a77502826..49ce83ff20 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -147,6 +147,9 @@ struct name_component
struct mapped_index_base
{
+ mapped_index_base () = default;
+ DISABLE_COPY_AND_ASSIGN (mapped_index_base);
+
/* The name_component table (a sorted vector). See name_component's
description above. */
std::vector<name_component> name_components;
prev parent reply other threads:[~2018-05-21 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 16:06 Tom Tromey
2018-05-20 23:59 ` Simon Marchi
2018-05-21 15:52 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muwt2f7s.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox