From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72849 invoked by alias); 8 Jul 2018 16:25:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72629 invoked by uid 89); 8 Jul 2018 16:24:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:24:50 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 2707D17DBE for ; Sun, 8 Jul 2018 11:24:26 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cCU6fqK2YbXuJcCU6fzsKL; Sun, 08 Jul 2018 11:24:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Dfa3D15faJJr63xdZwYmjSUx2Yc8kqnMm3DCftZQ/w=; b=dk6vag0udfAPj5ELVA+3uovq/6 wLjEyAbHCkLDw2ufxKcBjNY5oOGn4BT8ZBilUEeYsCT0t6wVmcqi9nRKT7nVba/pftB2JYMKI2cu9 XT/vV17NzSnlRIlUk/87YpU/b; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:42976 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fcCU5-001RJC-Tw; Sun, 08 Jul 2018 11:24:26 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 01/42] Use new and delete for buildsym_compunit References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-2-tom@tromey.com> <8a3cd7f5-f328-55c8-2762-3aa315e339c1@redhat.com> Date: Sun, 08 Jul 2018 16:25:00 -0000 In-Reply-To: <8a3cd7f5-f328-55c8-2762-3aa315e339c1@redhat.com> (Keith Seitz's message of "Thu, 5 Jul 2018 11:49:56 -0700") Message-ID: <87muv166h2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00184.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> I've got one general question: Keith> Since these variables will later become private, should they not also (some time) be renamed? Keith> [I think this should/could be a follow-on patch -- no changes needed here.] Keith> PS: [...] Thanks for the patch :) I wrote a ChangeLog entry & a description and tacked it on to the end of the series. Tom